refactor get flag to throw open feature errors and handle targeting key error #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billlynch
requested review from
ammar1x,
andreas-karlsson,
tonyskn and
varmenise
as code owners
Billlynch
force-pushed
the
apply_rework
branch
from
df754b9 to
d4462f9
Compare
Billlynch
changed the title
fabriziodemaria
approved these changes
Nov 21, 2023
Member
fabriziodemaria
left a comment
fabriziodemaria
left a comment
There was a problem hiding this comment.
Approving, although to be more compliant to the OF specification we should probably address my comment?
Billlynch
requested review from
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There, I just made a Pull Request!
Currently we set default value, error code and error message manually in the providers, this can make reading the getFlag function more difficult. OpenFeature's SDK will catch OF errors and map these in the exact same way. So we can simplify the logic with these errors. This is pre-work to make apply logic easier to adjust in the near future.
Also added throwing invalid context error when confidence returns with a reason of targeting key error
✔️ Checklist