Repository navigation
Let the live ITs follow TYPESAFE_BASE_URL and document using Laya - #9
Merged
Merged
Conversation
The ITs pinned the hosted base URL, so they could only run against Jev. Dropping the pin lets TypeSafeClient.builder() fall back to TYPESAFE_BASE_URL, which makes the ITs runnable against any server speaking the System One protocol, such as a local laya-serve. Add a "Using Laya" page under Client: running laya-serve, pointing the plain client and the Boot starter at it, the protocol differences measured against Laya 0.3.21 (no /v1/models, no request id, nouls need instructions, error bodies without a type) and how its answers compare with Jev's on the demos, including its sensitivity to the order of the state's fields and its weakness on criteria that need world knowledge, such as physical plausibility. Update the TYPESAFE_BASE_URL warnings in the README and the starter page accordingly. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Label the demo comparison as measured on Laya 0.3.11 and drop its plausibility row, which disagreed with the controlled 0.3.21 numbers in the world-knowledge note; the note now carries both phrasings. List validation status codes among the ITs' expected failures, drop the CI claim from the intro, and say in the README that the ITs talk to TYPESAFE_BASE_URL when it is set. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laya's
laya-serve(laya#31) exposes Jev'sPOST /v1/systemoneprotocol. This PR makes the project usable against it and documents what to expect.TYPESAFE_BASE_URL. The ITs pinned.baseUrl(TypeSafeConstants.DEFAULT_BASE_URL), so they could only hit the hosted API. With the pin dropped,TypeSafeClient.builder()falls back toTYPESAFE_BASE_URL, so the same ITs run against any compatible server. TheTYPESAFE_BASE_URLwarnings in the README and on the starter page now say so.laya-serve, on port 8002 to avoid clashing withmkdocs serve/v1/models, no request id,output_tokensalways 0, nouls need instructions,{"detail"}errors without a type, and different validation status codes (a malformed question is 422 where Jev answers 400; anullstate is 400 where Jev answers 422)Against Laya, the SDK handled every response without changes; all failing ITs are protocol gaps or answer-quality differences, not SDK bugs.