Fixes #101: Moved existing RefreshEndpoint logic to a new RefreshSupport class. #103
Conversation
| * | ||
| * @author Venil Noronha | ||
| */ | ||
| public class RefreshSupport { |
There was a problem hiding this comment.
Not so keen on the name. Maybe EnvironmentRefresher? @dsyer?
There was a problem hiding this comment.
Yeah, need a better name. We already have EnvironmentManager. What about ContextRefresher? I like the way that ApplicationEvents provide an extensibility already, though (you can listen for the event if you want to refresh more stuff). Maybe the ContextRefresher could just emit an event, and all the other features can be listeners?
There was a problem hiding this comment.
And log the keys as a different type of event?
There was a problem hiding this comment.
I've renamed the class to ContextRefresher. I didn't get the ApplicationEvents part. Are we talking about publishing a new event along with EnvironmentChangeEvent?
2. Moved ContextSupport bean creation to RefreshAutoConfiguration.
|
@spencergibb I've done the necessary changes. Could you please review? Also, do guide me with the |
|
@dsyer is this ok after we've gone into RC mode? |
|
Fine I think (it's not really a new feature). |
* pull103: Moved RefreshEndpoint logic to ContextRefresher.
|
Squashed and merged via 1e71c56 |
|
Thank you! |
3 participants
Hi,
I've moved RefreshEndpoint's logic to RefreshSupport and delegated the refresh call to it. One can now use RefreshSupport outside actuator. Please verify and merge.
My ICLA Number: 149720151120072904
Thanks,
Venil Noronha