Create a ServiceRegistry interface. #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.springframework.beans.BeansException; | ||
| import org.springframework.boot.context.embedded.EmbeddedServletContainerInitializedEvent; | ||
| import org.springframework.cloud.client.discovery.event.InstanceRegisteredEvent; | ||
| import org.springframework.cloud.client.serviceregistry.Registration; |
Member
Author
There was a problem hiding this comment.
I don't like how this is mixed up here. How about I move *Lifecycle to it's own package?
Member
Author
There was a problem hiding this comment.
In fact, DiscoveryLifecycle doesn't even make sense anymore. Maybe AutoRegistration? It's not a function of discovery at all.
Contributor
|
Can you explain in a few words how do you see it work? Like what the flow is cause I don't quite follow it ATM :/ |
spencergibb
force-pushed
the
service-registry
branch
from
d0b74eb to
e0c6acd
Compare
Allows service discovery systems to register more than one instance. Automatic registration will still take place. fixes gh-9
Created AbstractAutoServiceRegistration with new methods and reference to ServiceRegistry. It extends AbstractDiscoveryLifecycle.
spencergibb
force-pushed
the
service-registry
branch
from
9c9c026 to
81993a4
Compare
|
Is there any plan to merge and release it? |
Member
Author
|
Closed via bf4b6e3 @yidongnan see spring-cloud-release milestones for tentative release dates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows service discovery systems to register more than one instance.
Automatic registration will still take place.
fixes gh-9
/cc @dsyer @adriancole @marcingrzejszczak