Add new properties to inetutils: useOnlySiteLocalInterfaces and preferredNetworks #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } | ||
|
|
||
| for (String regex : this.properties.getPreferredNetworks()) { |
Member
There was a problem hiding this comment.
I'm a bit confused here. Why is prefferedNetworks being ignored?
Contributor
Author
There was a problem hiding this comment.
Look like a bug.
if (address.getHostAddress().matches(regex) || address.getHostAddress().startsWith(regex))must be replaced by:
if (!address.getHostAddress().matches(regex) && !address.getHostAddress().startsWith(regex))Now I use only useOnlySiteLocalInterfaces on production. prefferedNetworks is planned to be used in next months.
|
@tjuchniewicz Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@tjuchniewicz Thank you for signing the Contributor License Agreement! |
spencergibb
added a commit
that referenced
this pull request
Aug 18, 2016
* ebjwc-gh-114: Add new properties to customize InetUtils.
Member
|
Squashed and merged via 2da3fed |
mbenson
pushed a commit
to mbenson/spring-cloud-commons
that referenced
this pull request
Jun 5, 2018
* ebjwc-spring-cloudgh-114: Add new properties to customize InetUtils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-114