Fixes issue gh-153 - multiple bootstrap contexts with hierarchy #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
reviewed
Jan 26, 2017
| */ | ||
| public class BootstrapListenerHierarchyIntegrationTests { | ||
|
|
||
| private ConfigurableApplicationContext context; |
Contributor
Author
There was a problem hiding this comment.
Thanks @spencergibb, this is fixed - the variable is now local to each test.
Member
|
ping @dsyer |
Member
|
@bijukunjummen will you rebase? |
bijukunjummen
force-pushed
the
gh-153
branch
from
e40824b to
07b1b89
Compare
Contributor
Author
|
Done @spencergibb. |
Contributor
|
Fixed (I think in a better way, but only time will tell) in 331e790. I borrowed the test case though, thanks! |
Contributor
Author
|
Awesome, yes your fix appears way simpler @dsyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced additional checks to ensure that the bootstrap context is not already present in the hierarchy before adding one. Attempts to fix #153