Skip to content

gh-204 Introduce putMetadata() and setMetadata() function to ServiceInstance #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smcvb wants to merge 7 commits into from
Closed

gh-204 Introduce putMetadata() and setMetadata() function to ServiceInstance #209

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15cd2bc
gh-204 Introduce putMetadata() and setMetadata() to ServiceInstance
May 16, 2017
160efae
gh-204 Implement new functions in DefaultServiceInstance
May 16, 2017
7669d4b
gh-204 Implement new functions in SimpleServiceInstance
May 16, 2017
ee81e60
Merge remote-tracking branch 'origin/master' into issue204
Dec 4, 2017
a341eb6
Reorder functions a little
Dec 4, 2017
039cff5
Add empty default functionality for put and set metadata
Dec 5, 2017
5a232a7
Little clean up
Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Little clean up 
-Set constructor parameters on one line
-Add javadoc for 'instance' parameter

[#204]
  • Loading branch information
smcvb committed Dec 5, 2017
commit 5a232a76b91756880de0d2f075446281231bace5
8 changes: 4 additions & 4 deletions ...-cloud-commons/src/main/java/org/springframework/cloud/client/DefaultServiceInstance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ public DefaultServiceInstance(String serviceId, String host, int port, boolean s
this.metadata = metadata;
}

public DefaultServiceInstance(String serviceId, String host, int port,
boolean secure) {
this(serviceId, host, port, secure, new LinkedHashMap<String, String>());
public DefaultServiceInstance(String serviceId, String host, int port, boolean secure) {
this(serviceId, host, port, secure, new LinkedHashMap<>());
}

@Override
Expand Down Expand Up @@ -103,7 +102,8 @@ public URI getUri() {

/**
* Create a uri from the given ServiceInstance's host:port
* @param instance
*
* @param instance a {@link ServiceInstance} to create an {@link java.net.URI} out of.
* @return URI of the form (secure)?https:http + "host:port"
*/
public static URI getUri(ServiceInstance instance) {
Expand Down