A proposed fix for issue #26 fixes #26 #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I see I've made an invalid assumption in my pull request that the Property Source named 'bootstrap' actually contains the properties from bootstrap.properties or bootstrap.yml. I also see that this issue was previously requested - spring-cloud/spring-cloud-config#57 and marked as Closed but I don't see how this would allow me to set the bootstrapped propertysources as the last PropertySources. Just for some background I'm not using the ConfigServer but a custom property source that delegates to ZooKeeper for properties but we want the ability to specify the overrides locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be the functionality I was suggesting.
If you are happy with the changes and property names I'll do up some unit tests.