Polish doc #68
Closed
Polish doc #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Not sure why this doesn't get included. The blob link renders a github page so if it does get included it would break.
Contributor
Author
There was a problem hiding this comment.
Look at the current doc. It just doesn't work. I don't know either.
Member
There was a problem hiding this comment.
As far as I can see this is the only place we try to include content via a url in our main docs. The readme's do it, but they get processed differently. Maybe this should just be removed or copied in for now until that get's figured out.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not manage to fix the include for
https://github.com/spring-cloud/spring-cloud-build/blob/master/docs/src/main/asciidoc/contributing-docs.adocwhich still show up as plain text in the generated doc.Maybe the
RibbonAutoConfigurationreference is a bit out of place in an introduction?