Skip to content

fix Endpoint ID 'service-registry' contains invalid characters, please migrate to a valid format #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spencergibb merged 1 commit into from
Mar 29, 2020
Merged

fix Endpoint ID 'service-registry' contains invalid characters, please migrate to a valid format #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix Endpoint ID 'service-registry' contains invalid characters, pleas… 
…e migrate to a valid format
  • Loading branch information
@nkonev
nkonev committed Mar 6, 2020
commit 1fdb495229a6685a0eee0ba35b4d44eaf92c4e94
2 changes: 1 addition & 1 deletion ...va/org/springframework/cloud/client/serviceregistry/endpoint/ServiceRegistryEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
* @author Spencer Gibb
*/
@SuppressWarnings("unchecked")
@Endpoint(id = "service-registry")
@Endpoint(id = "serviceregistry")
public class ServiceRegistryEndpoint {

private final ServiceRegistry serviceRegistry;
Expand Down
4 changes: 2 additions & 2 deletions ...g/springframework/cloud/client/serviceregistry/endpoint/ServiceRegistryEndpointTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ public class ServiceRegistryEndpointTests {

@Test
public void testGet() throws Exception {
this.mvc.perform(get(BASE_PATH + "/service-registry")).andExpect(status().isOk())
this.mvc.perform(get(BASE_PATH + "/serviceregistry")).andExpect(status().isOk())
.andExpect(content().string(containsString(MYSTATUS)));
}

@Test
public void testPost() throws Exception {
Map<String, String> status = Collections.singletonMap("status", UPDATED_STATUS);
this.mvc.perform(post(BASE_PATH + "/service-registry")
this.mvc.perform(post(BASE_PATH + "/serviceregistry")
.content(new ObjectMapper().writeValueAsString(status))
.contentType(MediaType.APPLICATION_JSON)).andExpect(status().isOk());
then(this.serviceRegistry.getUpdatedStatus().get()).isEqualTo(UPDATED_STATUS);
Expand Down