Skip to content

Add retry support for blocking LoadBalancer #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMaciaszek merged 11 commits into from
Sep 24, 2020
Merged

Add retry support for blocking LoadBalancer #832

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1d44150
Add LoadBalancerProperties and BlockingLoadBalancedRetryPolicy. Add s…
OlgaMaciaszek Sep 22, 2020
08d6fd8
Add BlockingLoadBalancedRetryFactory
OlgaMaciaszek Sep 22, 2020
2e07d26
Move retry properties to LoadBalancerRetryProperties.
OlgaMaciaszek Sep 22, 2020
8cb08d5
Refactor and remove deprecations, fix checkstyle.
OlgaMaciaszek Sep 22, 2020
c84fa6a
Add BlockingLoadBalancedRetryPolicy to autoconfiguration. Set default…
OlgaMaciaszek Sep 23, 2020
f0d4bcc
Allow using @Order on LoadBalancedRetryFactory beans.
OlgaMaciaszek Sep 23, 2020
f8e0ab2
Add tests. Reformat tests. Add explanatory comments.
OlgaMaciaszek Sep 23, 2020
cde8b47
Add documentation.
OlgaMaciaszek Sep 23, 2020
ed8b59f
Fix javadoc.
OlgaMaciaszek Sep 23, 2020
e5e1f84
Fix docs after review.
OlgaMaciaszek Sep 24, 2020
e14e2e4
Change field name.
OlgaMaciaszek Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix docs after review.
  • Loading branch information
@OlgaMaciaszek
OlgaMaciaszek committed Sep 24, 2020
commit e5e1f84ccd8a21602bb7879c63dd744bbcacf354
6 changes: 3 additions & 3 deletions docs/src/main/asciidoc/spring-cloud-commons.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,16 +461,16 @@ If you would like to implement a `BackOffPolicy` in your retries, you need to cr
===== Ribbon-based retries

For the Ribbon-backed implementation, the load-balanced `RestTemplate` honors some of the Ribbon configuration values related to retrying failed requests.
You can use `client.ribbon.MaxAutoRetries`, `client.ribbon.MaxAutoRetriesNextServer`, and `client.ribbon.OkToRetryOnAllOperations` properties.
You can use the `client.ribbon.MaxAutoRetries`, `client.ribbon.MaxAutoRetriesNextServer`, and `client.ribbon.OkToRetryOnAllOperations` properties.

See the https://github.com/Netflix/ribbon/wiki/Getting-Started#the-properties-file-sample-clientproperties[Ribbon documentation] for a description of what these properties do.

===== Spring Cloud LoadBalancer-based retries

For the Spring Cloud LoadBalancer-backed implementation, you can set:

- `spring.cloud.loadbalancer.retry.maxRetriesOnSameServiceInstance` - indicates how many times a request should be retried on the same ServiceInstance (counted separately for every selected instance)
- `spring.cloud.loadbalancer.retry.maxRetriesOnNextServiceInstance` - indicates how many times a request should be retried a newly selected ServiceInstance
- `spring.cloud.loadbalancer.retry.maxRetriesOnSameServiceInstance` - indicates how many times a request should be retried on the same `ServiceInstance` (counted separately for every selected instance)
- `spring.cloud.loadbalancer.retry.maxRetriesOnNextServiceInstance` - indicates how many times a request should be retried a newly selected `ServiceInstance`
- `spring.cloud.loadbalancer.retry.retryableStatusCodes` - the status codes on which to always retry a failed request.

WARN:: If you chose to override the `LoadBalancedRetryFactory` while using the Spring Cloud LoadBalancer-backed approach, make sure you annotate your bean with `@Order` and set it to a higher precedence than `1000`, which is the order set on the `BlockingLoadBalancedRetryFactory`.
Expand Down