AMQP-200: Listener Exceptions Should be Logged at at Least WARN level

[jamescarr]

Commits speak for themselves. Low hanging fruit that I thought I'd take since I got bit by this very issue today.

[garyrussell]

Should not log under warn after testing for isInfoEnabled (or isDebugEnabled). Always log at the same level as if test.

simply replace both with a single

if (logger.isWarnEnabled() {
logger.warn(...., ex);
}

(See JMS AMLC)

[jamescarr]

Thanks. Just updated the commit range.

[garyrussell]

James,

Before we go any further, have you reviewed and signed the Individual Contributor Agreement?

https://support.springsource.com/spring_committer_signup

Thanks

[jamescarr]

Yes. I did when I contributed some changes last year.
On Nov 15, 2011 11:20 AM, "Gary Russell" <
[email protected]>
wrote:

James,

Before we go any further, have you reviewed and signed the Individual
Contributor Agreement?

https://support.springsource.com/spring_committer_signup

Thanks

---

Reply to this email directly or view it on GitHub:
#15 (comment)

[garyrussell]

Great!

You should remove this last else if{...} stanza; it will never be executed because the one above it will run.

Thanks.

[james-carr]

Changes made

[garyrussell]

Mark,

LGTM - ok to merge (w/ squash).