Skip to content

Conversation

@helena
Copy link

@helena helena commented Feb 22, 2011

Added a level of indirection for broker admin functionality between Rabbit control actions(module, function) and their respective Erlang converters that also takes broker versioning into account. This allows us to only modify one class for future Rabbit internal API changes for control actions versus 2 which were using hard-coded strings in both.

Added get version converter and call functions.

Did not yet test on pre 2.3.1 broker

Helena Edelson added 4 commits February 21, 2011 18:11
…ced with new ControlAction lookup.

Added creation of ControlAction types in RabbitControlErlangConverter to map module and function with the converter to use.
Modified ErlangTemplate to use new ControlAction interface but left 2 methods intact for those wishing to use the older access strategy.
Modified ErlangOperations to use ControlAction interface.
Conflicts:
	spring-rabbit/src/test/java/org/springframework/amqp/rabbit/admin/RabbitBrokerAdminIntegrationTests.java
Added new version converter to RabbitControlErlangConverter.
Added handling of broker control actions by version - per 2.3.0 internal rabbit api changes.
@helena
Copy link
Author

helena commented Feb 23, 2011

Added copyright to new classes

Helena Edelson added 5 commits February 23, 2011 07:10
…verter and in the creation of ControlActions that only need the default converter.

Added getter method in ErlangTemplate to handle use of appropriate converter to leverage existing declared converter.
Removed unused getter in ErlangTemplate for converter.
…thod in constructor.

Modified initializeDefaultErlangTemplate method - removed unused host parameter and peerNode declaration, to use the already-set nodeName value from constructor.
@dsyer
Copy link
Member

dsyer commented Feb 23, 2011

The ControlAction was looking a bit too complicated for what we need, so I just ignored this patch and slammed in a Map<String,String> called "moduleAdapter" in the RabbitBrokerAdmin. Hope that makes sense.

garyrussell pushed a commit that referenced this pull request Mar 17, 2015
Fix "rm -rf" instruictions
artembilan pushed a commit that referenced this pull request Aug 15, 2024
Bumps [org.springframework.retry:spring-retry](https://github.com/spring-projects/spring-retry) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/spring-projects/spring-retry/releases)
- [Commits](spring-projects/spring-retry@v2.0.6...v2.0.7)

---
updated-dependencies:
- dependency-name: org.springframework.retry:spring-retry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants