-
Notifications
You must be signed in to change notification settings - Fork 646
Control actions #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced with new ControlAction lookup. Added creation of ControlAction types in RabbitControlErlangConverter to map module and function with the converter to use. Modified ErlangTemplate to use new ControlAction interface but left 2 methods intact for those wishing to use the older access strategy. Modified ErlangOperations to use ControlAction interface.
Conflicts: spring-rabbit/src/test/java/org/springframework/amqp/rabbit/admin/RabbitBrokerAdminIntegrationTests.java
Added new version converter to RabbitControlErlangConverter. Added handling of broker control actions by version - per 2.3.0 internal rabbit api changes.
Author
|
Added copyright to new classes |
…verter and in the creation of ControlActions that only need the default converter. Added getter method in ErlangTemplate to handle use of appropriate converter to leverage existing declared converter. Removed unused getter in ErlangTemplate for converter.
…thod in constructor. Modified initializeDefaultErlangTemplate method - removed unused host parameter and peerNode declaration, to use the already-set nodeName value from constructor.
Member
|
The ControlAction was looking a bit too complicated for what we need, so I just ignored this patch and slammed in a Map<String,String> called "moduleAdapter" in the RabbitBrokerAdmin. Hope that makes sense. |
garyrussell
pushed a commit
that referenced
this pull request
Mar 17, 2015
Fix "rm -rf" instruictions
artembilan
pushed a commit
that referenced
this pull request
Aug 15, 2024
Bumps [org.springframework.retry:spring-retry](https://github.com/spring-projects/spring-retry) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/spring-projects/spring-retry/releases) - [Commits](spring-projects/spring-retry@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: org.springframework.retry:spring-retry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a level of indirection for broker admin functionality between Rabbit control actions(module, function) and their respective Erlang converters that also takes broker versioning into account. This allows us to only modify one class for future Rabbit internal API changes for control actions versus 2 which were using hard-coded strings in both.
Added get version converter and call functions.
Did not yet test on pre 2.3.1 broker