Refactor ExitStatus#isRunning for type-safety
#4783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sjiwon <[email protected]>
Signed-off-by: sjiwon <[email protected]>
Signed-off-by: sjiwon <[email protected]>
sjiwon
force-pushed
the
refactor/exit-status-type-safe-comparison
branch
from
f023ff8 to
62f5c3a
Compare
Signed-off-by: sjiwon <[email protected]>
Signed-off-by: sjiwon <[email protected]>
Signed-off-by: sjiwon <[email protected]>
|
LGTM 👍 Rebased, squashed and merged as 30b5120. Thank you for your contribution! |
fmbenhassine
added
pr-for: enhancement
in: core
for: backport-to-5.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the type-safety and readability of the ExitStatus#isRunning method in the Spring Batch core module.
Changes