Add working directory configuration option for Maven plugin run/start #6645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plamentotev Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
| } | ||
|
|
||
| public RunProcess(String... command) { | ||
| this.command = command; |
There was a problem hiding this comment.
This should call the other constructor
|
@plamentotev thanks for the PR, I've made a couple of comments. |
|
@snicoll Thanks. As this is my first PR to the Spring project I have a question. The issue is targeted for 1.5.0 but I can't see a branch for this version and the master is 1.4.1 so how features for 1.5.0 are developed? |
|
They aren't. Master is |
In some cases the working directory of a process is important.
Add configuration option that specifies the working directory of the application ran by Maven plugin's run/start goals. Closes gh-6243
|
@plamentotev Thank you for signing the Contributor License Agreement! |
snicoll
added a commit
that referenced
this pull request
Oct 11, 2016
* pr/6645: Polish contribution Add workingDirectory option for Maven plugin run/start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration option that specifies the working directory of the application ran by Maven plugin's run/start goals.
See #6243