Skip to content

Expose idleEventInterval to RabbitProperties. #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Expose idleEventInterval to RabbitProperties. #6666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Expose SimpleRabbitListenerContainerFactory#idleEventInterval to `R… 
…abbitProperties`.

Detecting idling listeners can be very handy and with this change idling time can be configured just by setting value for idle interval in `properties` or `yaml` file.
  • Loading branch information
@maciejwalkowiak
maciejwalkowiak committed Aug 16, 2016
commit 34a6921ed1f5b243b2bcdd8d92bbf0ae0d42c7ba
13 changes: 13 additions & 0 deletions ...configure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,11 @@ public static class Listener {
*/
private Boolean defaultRequeueRejected;

/**
* How often to publish idle container events.
*/
private Long idleEventInterval;

/**
* Optional properties for a retry interceptor.
*/
Expand Down Expand Up @@ -565,6 +570,14 @@ public void setDefaultRequeueRejected(Boolean defaultRequeueRejected) {
this.defaultRequeueRejected = defaultRequeueRejected;
}

public Long getIdleEventInterval() {
return idleEventInterval;
}

public void setIdleEventInterval(Long idleEventInterval) {
this.idleEventInterval = idleEventInterval;
}

public ListenerRetry getRetry() {
return this.retry;
}
Expand Down
3 changes: 3 additions & 0 deletions ...ringframework/boot/autoconfigure/amqp/SimpleRabbitListenerContainerFactoryConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public void configure(SimpleRabbitListenerContainerFactory factory,
if (listenerConfig.getDefaultRequeueRejected() != null) {
factory.setDefaultRequeueRejected(listenerConfig.getDefaultRequeueRejected());
}
if (listenerConfig.getIdleEventInterval() != null) {
factory.setIdleEventInterval(listenerConfig.getIdleEventInterval());
}
ListenerRetry retryConfig = listenerConfig.getRetry();
if (retryConfig.isEnabled()) {
RetryInterceptorBuilder<?> builder = (retryConfig.isStateless()
Expand Down
2 changes: 2 additions & 0 deletions ...c/test/java/org/springframework/boot/autoconfigure/amqp/RabbitAutoConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ public void testRabbitListenerContainerFactoryWithCustomSettings() {
"spring.rabbitmq.listener.maxConcurrency:10",
"spring.rabbitmq.listener.prefetch:40",
"spring.rabbitmq.listener.defaultRequeueRejected:false",
"spring.rabbitmq.listener.idleEventInterval:5",
"spring.rabbitmq.listener.transactionSize:20");
SimpleRabbitListenerContainerFactory rabbitListenerContainerFactory = this.context
.getBean("rabbitListenerContainerFactory",
Expand All @@ -319,6 +320,7 @@ public void testRabbitListenerContainerFactoryWithCustomSettings() {
.isSameAs(this.context.getBean("myMessageConverter"));
assertThat(dfa.getPropertyValue("defaultRequeueRejected"))
.isEqualTo(Boolean.FALSE);
assertThat(dfa.getPropertyValue("idleEventInterval")).isEqualTo(5L);
Advice[] adviceChain = (Advice[]) dfa.getPropertyValue("adviceChain");
assertThat(adviceChain).isNotNull();
assertThat(adviceChain.length).isEqualTo(1);
Expand Down