Skip to content

Fix incorrect property name when initializing OAuth2 client #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix incorrect property name when initializing OAuth2 client #9944

wants to merge 2 commits into from

Conversation

@christian-sahlmann
Copy link
Contributor

@christian-sahlmann christian-sahlmann commented Aug 3, 2017

The actual property name is security.oauth2.client.client-secret instead of security.oauth2.client.secret

@christian-sahlmann
Fix incorrect property name when initializing OAuth2 client
f25649f 
The actual property name is `security.oauth2.client.client-secret` instead of `security.oauth2.client.secret`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 3, 2017
@wilkinsona wilkinsona added this to the 1.5.7 milestone Aug 3, 2017
@wilkinsona wilkinsona added for: merge-with-amendments Needs some changes when we merge priority: normal type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 3, 2017
@wilkinsona
Copy link
Member

wilkinsona commented Aug 3, 2017 •
edited
Loading

Thanks for the PR, @Cbuehler.

When we merge this we should update clientId to be client-id so that we're consistently using kebab-case.

@wilkinsona wilkinsona removed the for: merge-with-amendments Needs some changes when we merge label Aug 4, 2017
@wilkinsona wilkinsona closed this in 6babd41 Aug 9, 2017
wilkinsona added a commit that referenced this pull request Aug 9, 2017
@wilkinsona
Polish "Fix logged property names when initializing OAuth2 client"
e08d09f 
See gh-9944
wilkinsona added a commit that referenced this pull request Aug 9, 2017
@wilkinsona
Merge pull request #9944 from Christian Bühler
3cc22ec 
* gh-9944:
  Polish "Fix logged property names when initializing OAuth2 client"
  Fix logged property names when initializing OAuth2 client
@wilkinsona
Copy link
Member

wilkinsona commented Aug 9, 2017

Thanks again for the PR, @Cbuehler, and for taking care of the client-id tweak too.

wilkinsona added a commit that referenced this pull request Aug 9, 2017
@wilkinsona
Fix OAuth2 sample integration test to expect corrected property names
9750d2e 
See gh-9944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: bug A general bug

Projects

None yet

Milestone

1.5.7

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-sahlmann @wilkinsona @spring-projects-issues