Skip to content

Check if the serialized value is instance of Map. #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ptahchiev wants to merge 1 commit into from
Closed

Check if the serialized value is instance of Map. #219

ptahchiev wants to merge 1 commit into from

Conversation

@ptahchiev
Copy link

@ptahchiev ptahchiev commented Aug 5, 2016

Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
Make sure that:

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
  • You provide your full name and an email address registered with your GitHub account. If you’re a first-time submitter, make sure you have completed the Contributor’s License Agreement form.

Related to DATAREST-864

odrotbohm added a commit that referenced this pull request Sep 16, 2016
@odrotbohm
DATAREST-864 - NestedEntitySerializer now handles Maps correctly.
254c451 
Previously, NestedEntitySerializer failed to handle Maps correctly as the logic to convert the found values to nested resources tried to handle the values as is, not explicitly looking at the values instead.

We now use an explicit code path to turn the values into resources so that links pointing to other resources are rendered correctly.

Original pull request: #219.
odrotbohm added a commit that referenced this pull request Sep 19, 2016
@odrotbohm
DATAREST-864 - NestedEntitySerializer now handles Maps correctly.
95d62fb 
Previously, NestedEntitySerializer failed to handle Maps correctly as the logic to convert the found values to nested resources tried to handle the values as is, not explicitly looking at the values instead.

We now use an explicit code path to turn the values into resources so that links pointing to other resources are rendered correctly.

Original pull request: #219.
@odrotbohm
Copy link
Member

odrotbohm commented Sep 19, 2016

That's merged.

@odrotbohm odrotbohm closed this Sep 19, 2016
@odrotbohm odrotbohm self-assigned this Sep 19, 2016
This was referenced Dec 31, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@odrotbohm odrotbohm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptahchiev @odrotbohm