add convet function to vultr/v1_reservedip #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add test coverage under the authenticated test suite. |
|
@nickruhl I rebased you PR on master after I fixed the travis build. You probably want to fetch it and reset your local master to the new remote master. |
|
Thank you. Will look into this today.
…On Tue, Feb 4, 2020 at 9:58 PM dopry ***@***.***> wrote:
@nickruhl <https://github.com/nickruhl> I rebased you PR on master after
I fixed the travis build. You probably want to fetch it and reset your
local master to the new remote master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AJ333CSNCPZDO5SVN4S33Y3RBJBQZA5CNFSM4KQELLZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK2ETTY#issuecomment-582240719>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ333CWEAFLDFUKQNGULOTTRBJBQZANCNFSM4KQELLZA>
.
|
|
@nickruhl have you had a chance to update the tests? |
|
Hi. No I dropped this as I am no longer hosting in Vultr.
…On Mon, Aug 9, 2021 at 11:03 AM dopry ***@***.***> wrote:
@nickruhl <https://github.com/nickruhl> have you had a chance to update
the tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ333CS5GD3YHVXPDHYTZF3T4AC6VANCNFSM4KQELLZA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.