Skip to content

Conversation

@kaizhu256
Copy link
Member

this pr fixes following tests from falsely returning exit-code 0 when they fail or crash

npm run test asm
npm run test asm-memory-growth
npm run test wasm

for example

  1. ci-logs @ https://github.com/kaizhu256/sql.js/runs/3323383890?check_suite_focus=true clearly show above tests failing, but ci still passes.
  2. after applying patch, the ci fails as expected (https://github.com/kaizhu256/sql.js/runs/3323390337?check_suite_focus=true)

this could also be considered a regression of #423 (since nodejs v16+), and reverting that might fix the problem as well.

image

@lovasoa lovasoa merged commit 05f66ee into sql-js:master Aug 13, 2021
@lovasoa
Copy link
Member

lovasoa commented Aug 13, 2021

thanks :)

@kaizhu256 kaizhu256 deleted the unhandled_rejections branch August 13, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants