Skip to content

Support for asymmetic extents around negative values #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anomalizer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for asymmetic extents around negative values #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support for asymmetic extents around negative values
  • Loading branch information
@anomalizer
anomalizer committed Dec 29, 2015
commit bca656596935be2c09d4b2c62416ea5dbdc1aafe
12 changes: 8 additions & 4 deletions src/horizon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ cubism_contextPrototype.horizon = function() {
width = buffer.width = context.size(),
height = buffer.height = 30,
scale = d3.scale.linear().interpolate(d3.interpolateRound),
scale_neg = d3.scale.linear().interpolate(d3.interpolateRound),
metric = cubism_identity,
extent = null,
title = cubism_identity,
Expand Down Expand Up @@ -71,7 +72,9 @@ cubism_contextPrototype.horizon = function() {
}

// update the domain
scale.domain([0, max_ = max]);
max_ = max;
scale.domain([0, extent[1]]);
scale_neg.domain([0, -extent[0]]);

// clear for the new data
canvas.clearRect(i0, 0, width - i0, height);
Expand Down Expand Up @@ -109,13 +112,13 @@ cubism_contextPrototype.horizon = function() {

// Adjust the range based on the current band index.
var y0 = (j - m + 1) * height;
scale.range([m * height + y0, y0]);
y0 = scale(0);
scale_neg.range([m * height + y0, y0]);
y0 = scale_neg(0);

for (var i = i0, n = width, y1; i < n; ++i) {
y1 = metric_.valueAt(i);
if (y1 >= 0) continue;
canvas.fillRect(i, scale(-y1), 1, y0 - scale(-y1));
canvas.fillRect(i, scale_neg(-y1), 1, y0 - scale_neg(-y1));
}
}
}
Expand Down Expand Up @@ -185,6 +188,7 @@ cubism_contextPrototype.horizon = function() {
horizon.scale = function(_) {
if (!arguments.length) return scale;
scale = _;
scale_neg = _;
return horizon;
};

Expand Down