Python 2.5 Support #25
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our servers are still on Python 2.5 and I wanted to get a profile of Redis on these servers using this tool. Here are some of the changes I made:
iomodule isn't present, useStringIOjsonmodulle isn't present, usesimplejsonsimplejsonas a prerequisite inrequirements.txtutilsdirectory with anamedtupleimplementationarrayfrom thearraymodule with a type ofunsigned charif thebytearraytype isn't available.StringIOfrom theStringIOmodule ifBytesIOfrom theiomodule isn't availableAll tests pass on Python 2.5, 2.6 and 2.7.
I completely understand if you don't wish to pull in these changes, given that Python 2.5 support is extra work, I'm just happy to contribute in any way I can.
Thanks,
-Mark