fix(tui): Prompt from stdin breaks TUI #3930
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaljaykam
reviewed
Nov 6, 2025
kunaljaykam
left a comment
kunaljaykam
left a comment
There was a problem hiding this comment.
thanks @veracioux it fixes the issue. i have tested in fedora
Contributor
Author
|
@kunaljaykam yw. What's missing is windows support, which I tried to add but doesn't work. I don't have a windows setup rn so I asked @rekram1-node to implement it. If you have a windows setup and are willing to help out, i think @rekram1-node would appreciate it. @rekram1-node In any case, I think this PR is good to merge since it works for linux and doesn't break anything that wasn't already broken on windows (after reverting 53dc493) |
|
i don’t have a windows setup, but you can spin up a windows instance on aws or azure and test it there using windows terminal. |
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f1dc981 to
3e15a39
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f8ee907 to
6a9856d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3871.
I also reverted to the behavior from
v0.15.xwhere the resulting prompt isargs.prompt + stdin, whereas inv1.xit is currentlystdin + args.prompt.