-
Notifications
You must be signed in to change notification settings - Fork 3.2k
use acp client tools if available #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@haoxiangliew i was thinking about doing this, we should probably disable the opencode write tools then if the ACP provided ones are avialable no? |
|
to work with our tools & prompt I think we should just make the acp tools be called the exact same thing with the same prompts ideally. I think you could import the existing tools, and override / copy from them so that you only change the execute portions also you need to remember to keep the permissions system in place too |
take PR feedback into account: - Import existing tools and only modify `execute()` - No prompt change needed, reads, edits, and writes are executed as-is with a different interface - Keep permissions refactor ACP tools
25e6929 to
e4f4bbe
Compare
we don't need ACP for "does a file exist"
dd29567 to
35203c5
Compare
remove unused import remove unused import
35203c5 to
e1b0ab8
Compare
went thru a couple iterations on the design to get this done as cleanly as possible:
lmk what u think 👍 |
|
left a couple comments here. Also I'm gonna merge dev into your branch there was a bug in one of the tests that causes CI to run for a longgg time |
f1dc981 to
3e15a39
Compare
df8bdf9 to
0dd5039
Compare
f8ee907 to
6a9856d
Compare
Delegates file
reads,edits, andwritesto the ACP Client, if the ACP Client (such as Zed) supports these modifications.Brings
opencode acpmore in-line with@zed-industries/claude-code-acp