Skip to content

Conversation

@haoxiangliew
Copy link

Delegates file reads, edits, and writes to the ACP Client, if the ACP Client (such as Zed) supports these modifications.

Brings opencode acp more in-line with @zed-industries/claude-code-acp

acp

@rekram1-node
Copy link
Collaborator

@haoxiangliew i was thinking about doing this, we should probably disable the opencode write tools then if the ACP provided ones are avialable no?

@rekram1-node
Copy link
Collaborator

to work with our tools & prompt I think we should just make the acp tools be called the exact same thing with the same prompts ideally.

I think you could import the existing tools, and override / copy from them so that you only change the execute portions

also you need to remember to keep the permissions system in place too

@rekram1-node rekram1-node changed the title Allows ACP Clients (e.g., Zed) to edit files use acp client tools if available Nov 6, 2025
take PR feedback into account:
- Import existing tools and only modify `execute()`
- No prompt change needed, reads, edits, and writes are executed as-is
with a different interface
- Keep permissions

refactor ACP tools
@haoxiangliew haoxiangliew force-pushed the zed-acp-fixes branch 2 times, most recently from dd29567 to 35203c5 Compare November 6, 2025 05:47
remove unused import

remove unused import
@haoxiangliew
Copy link
Author

haoxiangliew commented Nov 6, 2025

to work with our tools & prompt I think we should just make the acp tools be called the exact same thing with the same prompts ideally.

I think you could import the existing tools, and override / copy from them so that you only change the execute portions

also you need to remember to keep the permissions system in place too

@rekram1-node

went thru a couple iterations on the design to get this done as cleanly as possible:

  • wanted to preserve the read,write,edit tools as-is instead of duplicating them across to acp
  • + no need to disable the native tools when using acp

lmk what u think 👍

@rekram1-node
Copy link
Collaborator

left a couple comments here. Also I'm gonna merge dev into your branch there was a bug in one of the tests that causes CI to run for a longgg time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants