-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Config update endpoint #4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
|
||
| export async function update(config: Info) { | ||
| const filepath = path.join(Instance.directory, "config.json") | ||
| let filepath = path.join(Instance.directory, "opencode.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So something I was thinking is that the config.ts state should track all the files it loaded configs for and it wouldn't be that useful in most places but it would allow opencode debug config to have some mode where we state where every file came from and what it had to help users debug
maybe if we had that we wouldn't need to do a file system search each time and then we could also use it to power the config debug command later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I think I know the perfect solution for this. I think I'll have an update later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rekram1-node I did some fiddling around. Turns out the idea I had in mind might involve a pretty significant refactor. Therefore it's probably best to leave this to you.
f1dc981 to
3e15a39
Compare
f8ee907 to
6a9856d
Compare
Fixes #4194.