-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix/init error handling #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix/init error handling #4249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration error screen - Added a new `InitErrorScreen` component to handle and display initialization errors. - Updated the local context to return safe dummy objects when an initialization error occurs. - Updated the App rendering to showcase `InitErrorScreen` on Init errors allowing users to easily exit the application. - Enhanced the sync context to capture and propagate initialization errors during data fetching.
Collaborator
|
@OpeOginni when I do an invalid theme i still get this: Theme: |
Contributor
Author
|
Yeah, ill go ahead to add these types of errors in 🫡 |
Collaborator
|
I think original issue was addressed but if you are up for it this can change to become better error handling for bad themes? |
Contributor
Author
|
@rekram1-node Moved the new fix to another PR , this one was a bit too complex to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves Issues #4245 and #4246
The Error needed to be render better, its tough because it’s thrown before the full TUI is initialized. To solve this, I kept the error state through initialization and, instead of rendering the main app, rendered
InitErrorScreenwhen appropriate.Required several iterations to get the flow working.
Screen.Recording.2025-11-12.at.15.12.40.mov