-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: restore ability to bind keys for model_cycle_favorite model_cycle_favorite_reverse (resolves #5198) #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ariane-emory
wants to merge
16
commits into
sst:dev
Choose a base branch
from
ariane-emory:fix/allow-model-cycle-favorites-keybinds
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: restore ability to bind keys for model_cycle_favorite model_cycle_favorite_reverse (resolves #5198) #5202
ariane-emory
wants to merge
16
commits into
sst:dev
from
ariane-emory:fix/allow-model-cycle-favorites-keybinds
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema - Add TUI handlers for favorite model cycling - Add missing types to JS SDK KeybindsConfig - Both keybinds default to 'none' to maintain no new default keybindings - Total: 28 lines across 3 files Resolves sst#5198
277b2aa to
b32a5d3
Compare
Restore the model_cycle_favorite and model_cycle_favorite_reverse keybindings that were accidentally removed from the UI configuration. These commands allow users to cycle through their favorite models with customizable keybinds. Changes: - Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema (default to 'none' to maintain no new default keybindings) - Restore UI command handlers for favorite model cycling in app.tsx - Regenerate SDK types to include the restored keybindings Resolves sst#5198
…e-favorites-keybinds
…e-favorites-keybinds
…e-favorites-keybinds
…e-favorites-keybinds
Contributor
Author
|
Corrupted by a bad merge, will fix. |
ae08dd6 to
2d7d73d
Compare
Contributor
Author
|
Fixed, uncorrupted. |
kcrommett
added a commit
to Latitudes-Dev/shuvcode
that referenced
this pull request
Dec 11, 2025
…d keys for model_cycle_favorite model_cycle_favorite_reverse Resolved conflict: kept .github/workflows/sync-zed-extension.yml deleted (fork-specific)
4d7b109 to
7200148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to bind keys for @kcrommett's
model_cycle_favourite/model_cycle_favorite_reversecommands was seemingly lost in a commit that occurred a day after these commands were added.This PR restores the ability to bind these commands to keys.
No default keybinding is assigned, therefore:
opencode.jsonfiles.opencode.jsonfile.Resolves #5198.