Skip to content

Conversation

@ariane-emory
Copy link
Contributor

@ariane-emory ariane-emory commented Dec 7, 2025

The ability to bind keys for @kcrommett's model_cycle_favourite / model_cycle_favorite_reverse commands was seemingly lost in a commit that occurred a day after these commands were added.

This PR restores the ability to bind these commands to keys.

No default keybinding is assigned, therefore:

  • users who want keybindings for these commands may set their preferred keys in theiropencode.json files.
  • nothing changes for users who do not choose set keys for these commands in their opencode.json file.

Resolves #5198.

- Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema
- Add TUI handlers for favorite model cycling
- Add missing types to JS SDK KeybindsConfig
- Both keybinds default to 'none' to maintain no new default keybindings
- Total: 28 lines across 3 files

Resolves sst#5198
@ariane-emory ariane-emory marked this pull request as draft December 9, 2025 00:53
@ariane-emory ariane-emory force-pushed the fix/allow-model-cycle-favorites-keybinds branch from 277b2aa to b32a5d3 Compare December 9, 2025 01:49
Restore the model_cycle_favorite and model_cycle_favorite_reverse keybindings
that were accidentally removed from the UI configuration. These commands allow
users to cycle through their favorite models with customizable keybinds.

Changes:
- Add model_cycle_favorite and model_cycle_favorite_reverse to Keybinds schema
  (default to 'none' to maintain no new default keybindings)
- Restore UI command handlers for favorite model cycling in app.tsx
- Regenerate SDK types to include the restored keybindings

Resolves sst#5198
@ariane-emory ariane-emory marked this pull request as ready for review December 9, 2025 01:51
@ariane-emory ariane-emory marked this pull request as draft December 10, 2025 23:30
@ariane-emory
Copy link
Contributor Author

Corrupted by a bad merge, will fix.

@ariane-emory ariane-emory force-pushed the fix/allow-model-cycle-favorites-keybinds branch from ae08dd6 to 2d7d73d Compare December 11, 2025 00:40
@ariane-emory
Copy link
Contributor Author

Fixed, uncorrupted.

@ariane-emory ariane-emory marked this pull request as ready for review December 11, 2025 00:47
kcrommett added a commit to Latitudes-Dev/shuvcode that referenced this pull request Dec 11, 2025
…d keys for model_cycle_favorite model_cycle_favorite_reverse

Resolved conflict: kept .github/workflows/sync-zed-extension.yml deleted (fork-specific)
@ariane-emory ariane-emory force-pushed the fix/allow-model-cycle-favorites-keybinds branch from 4d7b109 to 7200148 Compare December 11, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

model_cycle_favorite / model_cycle_favorite_reverse commands are no longer keybindable

1 participant