feat: Support custom default agent #5313
Open
+148
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
observerw
changed the title
defaultAgent fielddefault_agent field in config
🤔 Maybe some AI-generated error code
I've searched through the repo for the string "build" and replaced instances with the default agent from the global config. The `cfg.default_agent` is marked as non-null (with `!`) since a default value is set.
observerw
changed the title
default_agent field in config
Author
|
@rekram1-node I added a |
Collaborator
|
thanks! ill have to give it a test |
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Collaborator
|
/review |
|
lgtm |
7 tasks
| return merged | ||
| } | ||
|
|
||
| function firstPrimaryAgent(agents: Record<string, Agent>): string { |
Collaborator
There was a problem hiding this comment.
shouldn't it still default to build if it is enabled tho, rather than arbitrary first agent
Author
|
Wait I found several places (e.g. desktop app) need to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4443.
This pr is intend to replace #4447 since it seems buggy.