Skip to content

Fix for proper handling of relative links for assets of network-loaded STAC items #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gadomski merged 11 commits into from
Dec 12, 2025
Merged

Fix for proper handling of relative links for assets of network-loaded STAC items #1599

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e2629ea
fix for proper handling of absolute http URIs
spinto Dec 9, 2025
6061c6a
fix tests for windows
spinto Dec 9, 2025
962407a
added fix for handling of relative links to changelog
spinto Dec 10, 2025
2da6fae
Better function description
spinto Dec 11, 2025
9141676
Reworded changelog
spinto Dec 11, 2025
10f24e1
revert back change in item
spinto Dec 12, 2025
8d8a437
added explicit tests for get_absolute_href
spinto Dec 12, 2025
5e08cc8
use temporary path for get_absolute_href tests as windows does not li…
spinto Dec 12, 2025
aa039c1
More readable condition
spinto Dec 12, 2025
cf7f94b
separated windows and unix tests
spinto Dec 12, 2025
81891c5
fix lint checks
spinto Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests for windows
  • Loading branch information
@spinto
spinto committed Dec 9, 2025
commit 6061c6a65f2e8098479aff8a36d309a89847241c
31 changes: 15 additions & 16 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ def test_is_absolute_href() -> None:
("./item.json", False, None),
("../item.json", False, None),
("http://stacspec.org/item.json", True, None),
("/item.json", True, None),
("/item.json", False, "http://stacspec.org/"),
("http://stacspec.org/item.json", True, "http://stacspec.org/"),
]

Expand All @@ -217,15 +215,16 @@ def test_is_absolute_href_os_aware() -> None:
is_windows = os.name == "nt"
incl_drive_letter = path_includes_drive_letter()
test_cases = [
("/item.json", not incl_drive_letter),
("/home/someuser/Downloads/item.json", not incl_drive_letter),
("file:///home/someuser/Downloads/item.json", not incl_drive_letter),
("d:/item.json", is_windows),
("c:/files/more_files/item.json", is_windows),
("/item.json", not incl_drive_letter, None),
("/item.json", False, "http://stacspec.org/"),
("/home/someuser/Downloads/item.json", not incl_drive_letter, None),
("file:///home/someuser/Downloads/item.json", not incl_drive_letter, None),
("d:/item.json", is_windows, None),
("c:/files/more_files/item.json", is_windows, None),
]

for href, expected in test_cases:
actual = is_absolute_href(href)
for href, expected, start_href in test_cases:
actual = is_absolute_href(href, start_href)
assert actual == expected


Expand All @@ -234,15 +233,15 @@ def test_is_absolute_href_windows() -> None:
# Test cases of (href, expected)

test_cases = [
("item.json", False),
(".\\item.json", False),
("..\\item.json", False),
("c:\\item.json", True),
("http://stacspec.org/item.json", True),
("item.json", False, None),
(".\\item.json", False, None),
("..\\item.json", False, None),
("c:\\item.json", True, None),
("http://stacspec.org/item.json", True, None),
]

for href, expected in test_cases:
actual = is_absolute_href(href)
for href, expected, start_href in test_cases:
actual = is_absolute_href(href, start_href)
assert actual == expected


Expand Down