Potential Regression for NLog.Targets.Stackify converting NLog to a private dependency

[homiedopie]

Hi @snakefoot - Im creating this issue so that we can keep track of it. What do you think should be the best approach? This is just a first time making the NLog dependency as private. What are your thoughts?

[snakefoot]

Well I recommend that you restore NLog as standard dependency and remove PrivateAssets="all".

Could the issues with NLog v5 be caused by NLog.Targets.Stackify being strong-signed assembly ? (Something that was very important in the good old .NET Framework days when running as medium-trust on IIS). Usually fixed by using binding-redirects on NET Framework, which usually work automatically.

Again it would be easier if you could provide an example where NLog v5 fails, instead of having to guess.

[homiedopie]

@snakefoot - This is the issue

Exception: System.IO.FileLoadException: Could not load file or assembly 'NLog, Version=4.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'NLog, Version=4.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c'

Probably NLog loading the Target with bundled with older version of NLog.

Ill update it to beta2 and link up the latest NLog 5.x

Just adding for reference:

• https://stackoverflow.com/questions/41524346/stackify-nlog-intermittent-logging

[snakefoot]

Exciting with a StackOverflow link from 2017, about using NLog v5 BETA-version, since NLog v5 Final was released 2022.

I guess it is your way of saying that you will not provide a reproducible-example to look at?

When searching google for "The located assembly's manifest definition does not match the assembly reference" then it recommends to check binding-redirects.

If you feel PrivateAssets="all" is the correct solution, then I think you should add this to all references that all Stackify-libraries depends upon (And not just break NLog.Targets.Stackify in attempt to fix strong-version-issues)

[homiedopie]

When searching google for "The located assembly's manifest definition does not match the assembly reference" then it recommends to check binding-redirects.

@snakefoot - yup this was the first course of action. To be safe, I can just hard code the version so in case there's a major bump, we will just correctly address the issue as there might be breaking change. As for this version 5, there was no breaking change so I assume it will be just making it a private dependency. I tried replicating the issue but unable to make it work. For now, what will fix the issue is just match it with v5 and we can call it a day I believe.

If you feel PrivateAssets="all" is the correct solution, then I think you should add this to all references that all Stackify-libraries depends upon (And not just break NLog.Targets.Stackify in attempt to fix strong-version-issues)

I agree with this one. Doing this potentially break future versions of the appenders/libraries since we are not referencing something telling whats the right version to match with the StackifyLib.

Thanks for raising the concern on the PR. We really appreciate it. Ill create the beta2 with the 5.x reference and will reference this Issue.

[snakefoot]

Yes I hope people will be brave and move to the next major-version of NLog. Ex. NLog v5.2.2 that supports build-trimming without warnings.

And maybe also fix their own nuget-packages to support build-trimming (that has been enabled by default with NET7).

NLog v6 is currently on the agenda to optimize the support for build-trimming to also support AOT-builds without warnings (Improving the support for mobile-platforms)

[snakefoot]

@homiedopie Guess this issue can now be closed after #161 has been merged?

[homiedopie]

@snakefoot - Yes, now this can be closed. I already released the 3.0.0 version. Thanks again for your insights and help! Hope you have a great rest of the week!

[snakefoot]

It looks great. Thank you for the fast response, and hope you also have a wonderful week.