Skip to content

Conversation

@kgorro
Copy link
Contributor

@kgorro kgorro commented May 3, 2024

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgorro We need the copyright messages on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @t-lair

@homiedopie
Copy link
Contributor

@kgorro - Can you please check again and add ConfigureAwait(false) to async-await operations? To avoid blocking the synchronization context (if there are any)

@kgorro
Copy link
Contributor Author

kgorro commented May 22, 2024

@kgorro - Can you please check again and add ConfigureAwait(false) to async-await operations? To avoid blocking the synchronization context (if there are any)

@homiedopie I don't see any part of the code that needs configureawait(false) because mostly we need to wait for the response.

@kgorro kgorro merged commit 230f2c8 into master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants