Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment to queryParamPushdown test for clarity
  • Loading branch information
claude committed Nov 29, 2025
commit fd6bf0f3b533838cd8efd90c090d64481fcd372d
1 change: 1 addition & 0 deletions anysdk/registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -680,11 +680,12 @@
cfg := method.GetStackQLConfig()
assert.Assert(t, cfg != nil)

// Get queryParamPushdown config from the method's StackQL config
qpp, ok := cfg.GetQueryParamPushdown()

Check failure on line 684 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use cfg.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 684 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use cfg.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 684 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use cfg.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected queryParamPushdown config to exist")

// Test filter config - full OData operator support
filterPD, ok := qpp.GetFilter()

Check failure on line 688 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qpp.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 688 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qpp.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 688 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qpp.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected filter pushdown config to exist")
assert.Equal(t, filterPD.GetDialect(), "odata")
assert.Equal(t, filterPD.GetParamName(), "$filter") // OData default
Expand All @@ -703,7 +704,7 @@
assert.Assert(t, filterPD.IsColumnSupported("anyColumn"))

// Test select config
selectPD, ok := qpp.GetSelect()

Check failure on line 707 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qpp.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 707 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qpp.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 707 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qpp.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected select pushdown config to exist")
assert.Equal(t, selectPD.GetDialect(), "odata")
assert.Equal(t, selectPD.GetParamName(), "$select") // OData default
Expand All @@ -713,21 +714,21 @@
assert.Assert(t, selectPD.IsColumnSupported("anyColumn"))

// Test orderBy config
orderByPD, ok := qpp.GetOrderBy()

Check failure on line 717 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qpp.GetOrderBy() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 717 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qpp.GetOrderBy() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 717 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qpp.GetOrderBy() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected orderBy pushdown config to exist")
assert.Equal(t, orderByPD.GetDialect(), "odata")
assert.Equal(t, orderByPD.GetParamName(), "$orderby") // OData default
assert.Equal(t, orderByPD.GetSyntax(), "odata") // OData default

// Test top config
topPD, ok := qpp.GetTop()

Check failure on line 724 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qpp.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 724 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qpp.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 724 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qpp.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected top pushdown config to exist")
assert.Equal(t, topPD.GetDialect(), "odata")
assert.Equal(t, topPD.GetParamName(), "$top") // OData default
assert.Equal(t, topPD.GetMaxValue(), 0) // No maxValue set

// Test count config
countPD, ok := qpp.GetCount()

Check failure on line 731 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qpp.GetCount() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 731 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qpp.GetCount() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 731 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qpp.GetCount() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok, "expected count pushdown config to exist")
assert.Equal(t, countPD.GetDialect(), "odata")
assert.Equal(t, countPD.GetParamName(), "$count") // OData default
Expand All @@ -747,25 +748,25 @@
cfgAirports := methodAirports.GetStackQLConfig()
assert.Assert(t, cfgAirports != nil)

qppAirports, ok := cfgAirports.GetQueryParamPushdown()

Check failure on line 751 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use cfgAirports.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 751 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use cfgAirports.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 751 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use cfgAirports.GetQueryParamPushdown() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok)

// Test filter with restricted columns
filterAirports, ok := qppAirports.GetFilter()

Check failure on line 755 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qppAirports.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 755 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qppAirports.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 755 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qppAirports.GetFilter() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok)
assert.Assert(t, filterAirports.IsColumnSupported("Name"))
assert.Assert(t, filterAirports.IsColumnSupported("IcaoCode"))
assert.Assert(t, !filterAirports.IsColumnSupported("Location"), "Location is not in supportedColumns")

// Test select with restricted columns
selectAirports, ok := qppAirports.GetSelect()

Check failure on line 762 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qppAirports.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 762 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qppAirports.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 762 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qppAirports.GetSelect() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok)
assert.Assert(t, selectAirports.IsColumnSupported("Name"))
assert.Assert(t, selectAirports.IsColumnSupported("IataCode"))
assert.Assert(t, !selectAirports.IsColumnSupported("Location"))

// Test top with maxValue
topAirports, ok := qppAirports.GetTop()

Check failure on line 769 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Windows Build

cannot use qppAirports.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 769 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / MacOS Build

cannot use qppAirports.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)

Check failure on line 769 in anysdk/registry_test.go

View workflow job for this annotation

GitHub Actions / Linux Build

cannot use qppAirports.GetTop() (value of type bool) as error value in assignment: bool does not implement error (missing method Error)
assert.Assert(t, ok)
assert.Equal(t, topAirports.GetMaxValue(), 100)

Expand Down
Loading