Skip to content

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Mar 25, 2021

Description

Without this, npm install fails on Node ≥ 10.15.0 (to say nothing of 12.x or 14.x, which Gulp 3 doesn’t support at all):

$ npm install

> [email protected] prepare /home/anders/js/stacktrace.js
> gulp dist

internal/util/inspect.js:31
const types = internalBinding('types');
              ^

ReferenceError: internalBinding is not defined
    at internal/util/inspect.js:31:15
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
    at util.js:25:21
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
    at fs.js:42:21
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at Object.req [as require] (/home/anders/js/stacktrace.js/node_modules/natives/index.js:54:10)
    at Object.<anonymous> (/home/anders/js/stacktrace.js/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:37)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] prepare: `gulp dist`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/anders/.npm/_logs/2021-03-25T00_14_18_635Z-debug.log

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc stacktrace.js passes without errors
    • You don’t use JSCS anymore.
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Without this, ‘npm install’ fails on Node ≥ 10.15.0 (to say nothing of
12.x or 14.x, which Gulp 3 doesn’t support at all):

$ npm install

> [email protected] prepare /home/anders/js/stacktrace.js
> gulp dist

internal/util/inspect.js:31
const types = internalBinding('types');
              ^

ReferenceError: internalBinding is not defined
    at internal/util/inspect.js:31:15
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
    at util.js:25:21
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
    at fs.js:42:21
    at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
    at Object.req [as require] (/home/anders/js/stacktrace.js/node_modules/natives/index.js:54:10)
    at Object.<anonymous> (/home/anders/js/stacktrace.js/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:37)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] prepare: `gulp dist`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/anders/.npm/_logs/2021-03-25T00_14_18_635Z-debug.log

Signed-off-by: Anders Kaseorg <[email protected]>
@eriwen eriwen merged commit 710bba1 into stacktracejs:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants