- Add meta.type to rules
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iteral` which is set to "suggestion") - Adhere to standard linting on README example - Add `.editorconfig` to prep. IDEs for proper indentation before lint checking/fixing
Contributor
Author
|
Bump.. |
Contributor
Author
|
Any chance you can take a look? I don't think this change should be very controversial... |
Contributor
Author
|
Thank you. FWIW, the tool I mentioned is functional: https://github.com/brettz9/eslint-formatter-badger |
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: Add standard metadata.
What changes did you make? (Give an overview)
meta.typeto rules ("layout" for all rules butno-callback-literalwhich is set to "suggestion").editorconfigto prep. IDEs for proper indentation before lint checking/fixingWhich issue (if any) does this pull request address?
N/A
Is there anything you'd like reviewers to focus on?
While
meta.typeis normally used witheslint --fix-type(and you currently have no fixers), as official meta-data exposed to formatters, I am planning to use it in my badge formatter (which I expect to release soon; Update: now available at https://github.com/brettz9/eslint-formatter-badger ); it can show a summary of linting problems by type, e.g., "layout", "problem", or "suggestion". Regardless of how it may end up being used, it shouldn't hurt to clarify the intent of the rule by expressingmeta.type.