Skip to content

Upgrade jsonrpc to 17.0.0 #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanlee42 merged 5 commits into from
Feb 2, 2021
Merged

Upgrade jsonrpc to 17.0.0 #2052

sanlee42 merged 5 commits into from
Feb 2, 2021

Conversation

@sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Jan 22, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #2052 (89e3746) into master (c725f3f) will increase coverage by 0.13%.
The diff coverage is 4.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   33.89%   34.02%   +0.13%     
==========================================
  Files         464      464              
  Lines       40371    40244     -127     
  Branches    17801    17672     -129     
==========================================
+ Hits        13680    13687       +7     
+ Misses      13449    13322     -127     
+ Partials    13242    13235       -7
Flag Coverage Δ
unittests 34.02% <4.53%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/lib.rs 100.00% <ø> (ø)
rpc/client/src/chain_watcher.rs 25.59% <0.00%> (ø)
rpc/client/src/pubsub_client.rs 24.33% <0.00%> (-1.38%) ⬇️
rpc/server/src/module/contract_rpc.rs 18.37% <0.00%> (ø)
rpc/server/src/module/dev_rpc.rs 14.82% <0.00%> (ø)
rpc/server/src/module/network_manager_rpc.rs 9.68% <0.00%> (ø)
rpc/server/src/module/node_manager_rpc.rs 7.32% <0.00%> (ø)
rpc/server/src/module/node_rpc.rs 20.00% <0.00%> (ø)
rpc/server/src/module/pubsub.rs 33.23% <ø> (+0.23%) ⬆️
rpc/server/src/module/sync_manager_rpc.rs 6.53% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c725f3f...89e3746. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 22, 2021

Benchmark for 56bbdf3

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1305.9±244.97µs 1260.6±70.96µs +3.59%
block_apply/block_apply_10 347.7±3.80ms 344.7±5.05ms +0.87%
block_apply/block_apply_1000 35.9±0.11s 35.0±0.42s +2.57%
get_with_proof/db_store 44.6±0.94µs 44.7±0.57µs -0.22%
get_with_proof/mem_store 34.8±1.47µs 35.3±1.00µs -1.42%
put_and_commit/db_store/1 538.1±30.99µs 542.9±33.13µs -0.88%
put_and_commit/db_store/10 1638.5±105.75µs 1620.7±149.40µs +1.10%
put_and_commit/db_store/100 9.8±0.76ms 9.9±0.69ms -1.01%
put_and_commit/db_store/5 1011.9±117.41µs 1021.8±118.26µs -0.97%
put_and_commit/db_store/50 5.7±1.56ms 5.6±1.11ms +1.79%
put_and_commit/mem_store/1 77.0±4.26µs 76.8±4.16µs +0.26%
put_and_commit/mem_store/10 688.4±38.06µs 685.8±32.15µs +0.38%
put_and_commit/mem_store/100 6.3±0.22ms 6.4±0.25ms -1.56%
put_and_commit/mem_store/5 354.3±19.26µs 346.9±21.59µs +2.13%
put_and_commit/mem_store/50 3.2±0.12ms 3.2±0.13ms 0.00%
query_block/query_block_in(10)_times(100) 3.2±0.07ms 3.2±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 32.0±0.52ms 32.3±0.57ms -0.93%
query_block/query_block_in(10)_times(10000) 319.8±3.72ms 320.8±5.61ms -0.31%
query_block/query_block_in(1000)_times(100) 1421.7±9.85µs 1370.1±3.81µs +3.77%
query_block/query_block_in(1000)_times(1000) 14.1±0.19ms 13.7±0.11ms +2.92%
query_block/query_block_in(1000)_times(10000) 142.3±1.95ms 138.2±1.08ms +2.97%
storage_transaction 15.1±0.45ms 14.8±0.47ms +2.03%
vm/transaction_execution/1 350.7±3.63ms 350.6±2.11ms +0.03%
vm/transaction_execution/10 109.4±0.67ms 109.6±0.73ms -0.18%
vm/transaction_execution/20 101.3±0.94ms 102.0±2.03ms -0.69%
vm/transaction_execution/5 133.1±1.22ms 133.9±0.76ms -0.60%
vm/transaction_execution/50 115.3±1.30ms 116.8±1.02ms -1.28%

@sanlee42 sanlee42 requested review from fanngyuan, jolestar and nanne007 and removed request for nanne007 January 22, 2021 07:12
@github-actions
Copy link

github-actions bot commented Jan 22, 2021

Benchmark for 4684e75

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1560.2±69.31µs 1789.3±939.20µs -12.80%
block_apply/block_apply_10 397.1±2.17ms 393.5±3.01ms +0.91%
block_apply/block_apply_1000 41.6±0.17s 41.3±0.11s +0.73%
get_with_proof/db_store 47.0±0.99µs 46.7±0.84µs +0.64%
get_with_proof/mem_store 37.0±1.03µs 36.1±0.84µs +2.49%
put_and_commit/db_store/1 751.5±15.42µs 741.5±24.42µs +1.35%
put_and_commit/db_store/10 1949.3±177.72µs 1958.8±455.01µs -0.48%
put_and_commit/db_store/100 10.5±0.67ms 10.5±0.63ms 0.00%
put_and_commit/db_store/5 1356.4±476.28µs 1299.4±126.20µs +4.39%
put_and_commit/db_store/50 6.1±0.36ms 6.0±0.34ms +1.67%
put_and_commit/mem_store/1 79.6±4.14µs 78.9±4.02µs +0.89%
put_and_commit/mem_store/10 704.9±34.85µs 696.8±33.44µs +1.16%
put_and_commit/mem_store/100 6.5±0.24ms 6.5±0.23ms 0.00%
put_and_commit/mem_store/5 362.1±19.68µs 363.5±19.90µs -0.39%
put_and_commit/mem_store/50 3.4±0.15ms 3.3±0.12ms +3.03%
query_block/query_block_in(10)_times(100) 3.2±0.06ms 3.3±0.08ms -3.03%
query_block/query_block_in(10)_times(1000) 32.7±0.70ms 32.5±0.49ms +0.62%
query_block/query_block_in(10)_times(10000) 324.7±5.18ms 325.8±3.45ms -0.34%
query_block/query_block_in(1000)_times(100) 1433.1±6.28µs 1449.3±14.79µs -1.12%
query_block/query_block_in(1000)_times(1000) 14.8±0.15ms 14.7±0.21ms +0.68%
query_block/query_block_in(1000)_times(10000) 147.8±1.22ms 146.0±1.35ms +1.23%
storage_transaction 22.2±7.68ms 21.0±0.80ms +5.71%
vm/transaction_execution/1 361.5±1.96ms 363.8±1.97ms -0.63%
vm/transaction_execution/10 112.8±0.88ms 113.3±1.27ms -0.44%
vm/transaction_execution/20 104.7±0.78ms 105.5±0.74ms -0.76%
vm/transaction_execution/5 137.9±0.76ms 138.6±1.10ms -0.51%
vm/transaction_execution/50 121.2±2.19ms 121.3±1.51ms -0.08%

jolestar
jolestar approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 完了可以把 rpc/client/tests/client_server_test.rs 中的 test_in_async 打开试试看。

@github-actions
Copy link

github-actions bot commented Jan 22, 2021

Benchmark for 6dd5758

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1504.9±85.15µs 1516.8±59.58µs -0.78%
block_apply/block_apply_10 385.4±2.86ms 382.0±2.44ms +0.89%
block_apply/block_apply_1000 40.1±0.17s 40.1±0.12s 0.00%
get_with_proof/db_store 44.0±0.67µs 45.5±0.91µs -3.30%
get_with_proof/mem_store 35.4±0.59µs 35.0±0.52µs +1.14%
put_and_commit/db_store/1 718.5±26.94µs 714.7±64.97µs +0.53%
put_and_commit/db_store/10 1888.1±329.34µs 1833.7±185.54µs +2.97%
put_and_commit/db_store/100 10.2±0.69ms 10.2±0.65ms 0.00%
put_and_commit/db_store/5 1242.3±119.43µs 1293.3±437.16µs -3.94%
put_and_commit/db_store/50 5.9±0.39ms 5.8±0.38ms +1.72%
put_and_commit/mem_store/1 76.6±4.12µs 77.4±3.98µs -1.03%
put_and_commit/mem_store/10 683.3±41.69µs 680.0±31.78µs +0.49%
put_and_commit/mem_store/100 6.4±0.31ms 6.3±0.21ms +1.59%
put_and_commit/mem_store/5 348.0±23.19µs 348.2±20.57µs -0.06%
put_and_commit/mem_store/50 3.2±0.16ms 3.3±0.13ms -3.03%
query_block/query_block_in(10)_times(100) 3.2±0.06ms 3.3±0.06ms -3.03%
query_block/query_block_in(10)_times(1000) 32.4±0.38ms 32.4±0.60ms 0.00%
query_block/query_block_in(10)_times(10000) 325.2±4.99ms 328.2±5.55ms -0.91%
query_block/query_block_in(1000)_times(100) 1437.1±14.87µs 1453.7±12.10µs -1.14%
query_block/query_block_in(1000)_times(1000) 14.5±0.06ms 14.6±0.10ms -0.68%
query_block/query_block_in(1000)_times(10000) 144.7±0.95ms 145.4±1.05ms -0.48%
storage_transaction 19.9±1.10ms 20.3±4.66ms -1.97%
vm/transaction_execution/1 349.6±6.06ms 350.8±2.33ms -0.34%
vm/transaction_execution/10 109.3±0.31ms 109.2±1.06ms +0.09%
vm/transaction_execution/20 101.3±1.15ms 101.9±0.77ms -0.59%
vm/transaction_execution/5 133.9±1.66ms 134.2±0.91ms -0.22%
vm/transaction_execution/50 115.8±0.97ms 116.9±0.79ms -0.94%

@sanlee42 sanlee42 force-pushed the jsonrpc branch 2 times, most recently from 62c1161 to a868f62 Compare January 24, 2021 08:32
@github-actions
Copy link

github-actions bot commented Jan 24, 2021

Benchmark for e2c2d2d

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1455.0±181.21µs 1372.9±111.20µs +5.98%
block_apply/block_apply_10 348.3±32.45ms 336.1±1.53ms +3.63%
block_apply/block_apply_1000 36.6±0.42s 36.5±0.33s +0.27%
get_with_proof/db_store 45.2±0.21µs 47.4±1.46µs -4.64%
get_with_proof/mem_store 35.6±0.57µs 35.2±0.30µs +1.14%
put_and_commit/db_store/1 611.8±73.00µs 625.5±89.20µs -2.19%
put_and_commit/db_store/10 1850.9±349.40µs 1863.4±387.13µs -0.67%
put_and_commit/db_store/100 10.8±1.78ms 10.8±1.42ms 0.00%
put_and_commit/db_store/5 1165.6±272.02µs 1149.7±260.95µs +1.38%
put_and_commit/db_store/50 6.1±0.86ms 6.0±0.97ms +1.67%
put_and_commit/mem_store/1 76.8±3.85µs 77.4±3.96µs -0.78%
put_and_commit/mem_store/10 679.0±31.42µs 689.7±31.17µs -1.55%
put_and_commit/mem_store/100 6.4±0.21ms 6.3±0.29ms +1.59%
put_and_commit/mem_store/5 348.0±17.47µs 345.7±17.93µs +0.67%
put_and_commit/mem_store/50 3.3±0.12ms 3.2±0.16ms +3.13%
query_block/query_block_in(10)_times(100) 3.1±0.11ms 3.2±0.05ms -3.13%
query_block/query_block_in(10)_times(1000) 31.9±0.82ms 31.8±0.76ms +0.31%
query_block/query_block_in(10)_times(10000) 317.1±4.41ms 318.4±4.48ms -0.41%
query_block/query_block_in(1000)_times(100) 1419.1±9.50µs 1415.9±3.69µs +0.23%
query_block/query_block_in(1000)_times(1000) 14.2±0.04ms 13.9±0.13ms +2.16%
query_block/query_block_in(1000)_times(10000) 141.5±0.47ms 141.8±0.52ms -0.21%
storage_transaction 16.5±1.23ms 16.1±0.88ms +2.48%
vm/transaction_execution/1 349.2±1.19ms 346.8±1.12ms +0.69%
vm/transaction_execution/10 108.7±0.31ms 108.8±0.30ms -0.09%
vm/transaction_execution/20 101.6±0.97ms 100.6±0.46ms +0.99%
vm/transaction_execution/5 132.9±0.44ms 132.8±0.74ms +0.08%
vm/transaction_execution/50 116.0±0.55ms 117.1±1.62ms -0.94%

@jolestar jolestar linked an issue Jan 25, 2021 that may be closed by this pull request
Bump jsonrpc #1822
Closed
@github-actions
Copy link

github-actions bot commented Jan 26, 2021

Benchmark for e320a85

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1492.9±61.57µs 1459.4±63.64µs +2.30%
block_apply/block_apply_10 381.5±2.21ms 390.0±28.75ms -2.18%
block_apply/block_apply_1000 39.9±0.18s 39.8±0.15s +0.25%
get_with_proof/db_store 45.5±0.81µs 44.7±0.85µs +1.79%
get_with_proof/mem_store 35.2±0.59µs 35.4±0.60µs -0.56%
put_and_commit/db_store/1 702.6±29.50µs 696.0±20.45µs +0.95%
put_and_commit/db_store/10 1836.0±187.14µs 1828.7±186.02µs +0.40%
put_and_commit/db_store/100 10.3±0.82ms 10.5±2.66ms -1.90%
put_and_commit/db_store/5 1234.2±123.87µs 1227.1±128.59µs +0.58%
put_and_commit/db_store/50 5.9±0.41ms 5.9±0.37ms 0.00%
put_and_commit/mem_store/1 76.6±4.05µs 76.0±3.87µs +0.79%
put_and_commit/mem_store/10 680.4±33.01µs 665.8±34.31µs +2.19%
put_and_commit/mem_store/100 6.4±0.23ms 6.3±0.25ms +1.59%
put_and_commit/mem_store/5 351.8±18.21µs 348.4±19.85µs +0.98%
put_and_commit/mem_store/50 3.2±0.12ms 3.2±0.13ms 0.00%
query_block/query_block_in(10)_times(100) 3.2±0.11ms 3.2±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 32.8±0.82ms 31.7±0.82ms +3.47%
query_block/query_block_in(10)_times(10000) 323.6±6.77ms 314.4±5.21ms +2.93%
query_block/query_block_in(1000)_times(100) 1454.6±11.78µs 1386.1±15.08µs +4.94%
query_block/query_block_in(1000)_times(1000) 14.4±0.15ms 13.9±0.13ms +3.60%
query_block/query_block_in(1000)_times(10000) 143.6±1.81ms 139.8±1.60ms +2.72%
storage_transaction 19.3±0.89ms 19.5±0.60ms -1.03%
vm/transaction_execution/1 349.3±3.42ms 342.3±4.27ms +2.04%
vm/transaction_execution/10 105.2±0.94ms 103.5±1.58ms +1.64%
vm/transaction_execution/20 95.9±0.67ms 95.0±0.99ms +0.95%
vm/transaction_execution/5 130.2±1.67ms 127.8±1.75ms +1.88%
vm/transaction_execution/50 108.4±0.75ms 106.9±1.26ms +1.40%

@nanne007
Copy link
Member

nanne007 commented Jan 27, 2021

watch 卡住问题找到了。 jsonrpc 那边的bug， 我提了个PR，paritytech/jsonrpc#610 。等它那边 merge 吧。

@jolestar jolestar mentioned this pull request Feb 1, 2021
Closed
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Benchmark for 5a2c2c6

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 1550.0±118.44µs 1476.3±74.24µs +4.99%
block_apply/block_apply_10 395.4±2.71ms 384.3±2.70ms +2.89%
block_apply/block_apply_1000 41.7±0.45s 41.2±0.13s +1.21%
get_with_proof/db_store 44.9±0.78µs 45.2±0.84µs -0.66%
get_with_proof/mem_store 36.6±1.86µs 35.9±0.41µs +1.95%
put_and_commit/db_store/1 736.7±33.86µs 703.0±197.60µs +4.79%
put_and_commit/db_store/10 1991.2±796.37µs 1871.0±502.34µs +6.42%
put_and_commit/db_store/100 10.3±0.62ms 10.4±0.55ms -0.96%
put_and_commit/db_store/5 1274.4±129.21µs 1206.1±122.31µs +5.66%
put_and_commit/db_store/50 5.9±0.42ms 5.9±0.36ms 0.00%
put_and_commit/mem_store/1 78.8±4.31µs 78.5±4.39µs +0.38%
put_and_commit/mem_store/10 694.4±33.95µs 695.7±34.42µs -0.19%
put_and_commit/mem_store/100 6.5±0.38ms 6.5±0.27ms 0.00%
put_and_commit/mem_store/5 357.9±19.96µs 355.0±19.56µs +0.82%
put_and_commit/mem_store/50 3.3±0.12ms 3.3±0.13ms 0.00%
query_block/query_block_in(10)_times(100) 3.3±0.05ms 3.2±0.04ms +3.13%
query_block/query_block_in(10)_times(1000) 32.2±0.91ms 32.1±0.64ms +0.31%
query_block/query_block_in(10)_times(10000) 326.7±7.73ms 326.0±7.73ms +0.21%
query_block/query_block_in(1000)_times(100) 1455.9±17.31µs 1460.2±9.13µs -0.29%
query_block/query_block_in(1000)_times(1000) 14.4±0.12ms 14.4±0.05ms 0.00%
query_block/query_block_in(1000)_times(10000) 143.7±0.68ms 145.9±1.06ms -1.51%
storage_transaction 21.0±0.95ms 19.3±0.81ms +8.81%
vm/transaction_execution/1 369.6±2.35ms 369.9±3.41ms -0.08%
vm/transaction_execution/10 114.3±1.20ms 113.0±0.54ms +1.15%
vm/transaction_execution/20 105.2±0.80ms 105.6±0.70ms -0.38%
vm/transaction_execution/5 140.3±0.64ms 139.2±0.76ms +0.79%
vm/transaction_execution/50 120.7±1.01ms 121.4±1.11ms -0.58%

@sanlee42 sanlee42 merged commit 50defe0 into master Feb 2, 2021
@sanlee42 sanlee42 deleted the jsonrpc branch February 2, 2021 05:59
@sanlee42 sanlee42 mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanngyuan fanngyuan Awaiting requested review from fanngyuan

@nanne007 nanne007 Awaiting requested review from nanne007

1 more reviewer

@jolestar jolestar jolestar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump jsonrpc

4 participants

@sanlee42 @nanne007 @jolestar