add use selec_head to update startinfo and add some testing case #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
reviewed
Oct 13, 2023
| ); | ||
| let gas_schedule = GasSchedule::fetch_config(&remote_storage)?; | ||
| (gas_schedule, "gas schedule from GasSchedule") | ||
| let gas_schedule = { |
Contributor
There was a problem hiding this comment.
版本合的有问题，左边都是1.13.7的内容，右边是以前的代码
nkysg
reviewed
Oct 13, 2023
| // Executor external API | ||
| impl VMExecutor for StarcoinVM { | ||
| /// Execute a block of `transactions`. The output vector will have the exact same length as the | ||
| /// input vector. The discarded transactions will be marked as `TransactionStatus::Discard` and |
Contributor
There was a problem hiding this comment.
同以前, 版本合并的有问题，把TurboSTM代码都删了
nkysg
reviewed
Oct 13, 2023
| self, | ||
| ap_cache: &mut C, | ||
| ) -> Result< | ||
| ( |
nkysg
reviewed
Oct 13, 2023
| license = { workspace = true } | ||
| name = "starcoin-vm-types" | ||
| publish = { workspace = true } | ||
| version = "1.13.7" |
Contributor
There was a problem hiding this comment.
这里应该用1.13.7版本，现在变成1.13.5，版本合的有问题
nkysg
reviewed
Oct 13, 2023
| name = "transaction-builder-generator" | ||
| repository = { workspace = true } | ||
| version = "1.13.7" | ||
| version = "1.13.5" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information