Skip to content

Upgrade rust toolchain to 1.86.0 for dual-verse-dag#4612

Merged
sanlee42 merged 4 commits intodual-verse-dagfrom
upgrade_rust_toolchain_to_1.86.0
Aug 21, 2025
Merged

Upgrade rust toolchain to 1.86.0 for dual-verse-dag#4612
sanlee42 merged 4 commits intodual-verse-dagfrom
upgrade_rust_toolchain_to_1.86.0

Conversation

@simonjiao
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

* keep edition 2021 not changed
* fix clippy::empty_line_after_doc_comments warnings
* fix resolve clippy::doc_list_overindented warnings
* Fix clippy warnings: remove useless conversions and other formatting
* fix clippy::doc_list_item_without_indentation warnings
* fix non-local impl definition warnings
* fix clippy::elided_named_lifetimes warnings
* fix clippy::while_let_loop warning
* silence unexpected cfgs
@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade_rust_toolchain_to_1.86.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@simonjiao simonjiao requested review from Copilot, jackzhhuang, lushengguo and welbon and removed request for LemonHX, jolestar and yourmoonlight August 21, 2025 04:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Rust toolchain from version 1.82.0 to 1.86.0 for the dual-verse-dag project. The upgrade introduces compatibility changes across the codebase to work with the newer Rust version.

  • Toolchain version update from 1.82.0 to 1.86.0
  • Lifetime parameter simplifications using the '_ anonymous lifetime
  • Iterator method updates to use more modern alternatives

Reviewed Changes

Copilot reviewed 53 out of 56 changed files in this pull request and generated no comments.

File Description
rust-toolchain.toml Updates Rust channel from 1.82.0 to 1.86.0
Cargo.toml Updates rust-version and dependency versions, reorganizes patch sections
.github/workflows/build_test.yml Removes clippy lint flag and updates RUSTFLAGS
Multiple .rs files Simplifies lifetime parameters and modernizes iterator usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sanlee42 sanlee42 merged commit 981425a into dual-verse-dag Aug 21, 2025
2 of 4 checks passed
@sanlee42 sanlee42 deleted the upgrade_rust_toolchain_to_1.86.0 branch August 21, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants