Skip to content

Conversation

@jackzhhuang
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jackzhhuang jackzhhuang marked this pull request as draft August 25, 2025 02:22
@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch multi-accounts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Benchmark for 1febf27

Click to view benchmark
Test Base PR %
accumulator_append 922.1±190.63µs 961.2±205.48µs +4.24%
block_apply/block_apply_10 379.1±23.38ms 405.8±80.68ms +7.04%
block_apply/block_apply_1000 48.1±4.60s 47.7±5.43s -0.83%
get_with_proof/db_store 49.3±8.25µs 51.5±9.58µs +4.46%
get_with_proof/mem_store 38.6±3.98µs 39.5±5.54µs +2.33%
put_and_commit/db_store/1 139.1±13.47µs 134.8±21.96µs -3.09%
put_and_commit/db_store/10 1234.8±178.29µs 1145.8±118.46µs -7.21%
put_and_commit/db_store/100 11.0±0.90ms 16.2±3.03ms +47.27%
put_and_commit/db_store/5 683.6±141.98µs 606.9±65.88µs -11.22%
put_and_commit/db_store/50 5.7±0.66ms 5.7±0.73ms 0.00%
put_and_commit/mem_store/1 84.0±18.31µs 74.5±8.43µs -11.31%
put_and_commit/mem_store/10 1001.5±162.17µs 683.6±61.37µs -31.74%
put_and_commit/mem_store/100 7.8±1.63ms 7.2±1.27ms -7.69%
put_and_commit/mem_store/5 342.2±41.08µs 332.2±26.01µs -2.92%
put_and_commit/mem_store/50 3.7±0.58ms 3.5±0.65ms -5.41%
query_block/query_block_in(10)_times(100) 4.8±0.38ms 5.4±0.81ms +12.50%
query_block/query_block_in(10)_times(1000) 49.9±8.80ms 48.0±5.56ms -3.81%
query_block/query_block_in(10)_times(10000) 485.9±33.52ms 472.3±21.88ms -2.80%
query_block/query_block_in(1000)_times(100) 1223.1±152.35µs 1194.4±104.01µs -2.35%
query_block/query_block_in(1000)_times(1000) 16.2±3.36ms 11.3±0.76ms -30.25%
query_block/query_block_in(1000)_times(10000) 135.0±17.84ms 157.8±45.14ms +16.89%
storage_transaction 1029.0±331.13µs 1146.1±448.05µs +11.38%
vm/transaction_execution/1 439.0±25.81ms 490.8±82.75ms +11.80%
vm/transaction_execution/10 151.8±9.77ms 147.0±10.37ms -3.16%
vm/transaction_execution/20 163.0±17.80ms 153.0±14.31ms -6.13%
vm/transaction_execution/5 180.3±26.19ms 218.4±18.30ms +21.13%
vm/transaction_execution/50 167.7±13.96ms 165.9±10.47ms -1.07%

@github-actions
Copy link

Benchmark for 5808be8

Click to view benchmark
Test Base PR %
accumulator_append 889.2±166.50µs 1009.4±204.12µs +13.52%
block_apply/block_apply_10 410.6±57.34ms 379.3±34.28ms -7.62%
block_apply/block_apply_1000 47.1±2.42s 45.8±6.13s -2.76%
get_with_proof/db_store 45.8±2.57µs 56.1±12.62µs +22.49%
get_with_proof/mem_store 37.0±4.12µs 38.8±5.90µs +4.86%
put_and_commit/db_store/1 120.6±7.12µs 128.9±10.77µs +6.88%
put_and_commit/db_store/10 1069.4±65.88µs 1212.8±169.55µs +13.41%
put_and_commit/db_store/100 10.8±0.66ms 11.3±1.23ms +4.63%
put_and_commit/db_store/5 602.8±58.65µs 611.4±87.84µs +1.43%
put_and_commit/db_store/50 5.5±0.73ms 6.1±1.60ms +10.91%
put_and_commit/mem_store/1 72.1±8.01µs 79.9±16.19µs +10.82%
put_and_commit/mem_store/10 718.9±126.06µs 873.7±183.26µs +21.53%
put_and_commit/mem_store/100 6.7±0.41ms 7.0±0.64ms +4.48%
put_and_commit/mem_store/5 353.5±62.00µs 347.3±47.13µs -1.75%
put_and_commit/mem_store/50 3.4±0.44ms 3.6±0.68ms +5.88%
query_block/query_block_in(10)_times(100) 4.7±0.40ms 5.1±0.66ms +8.51%
query_block/query_block_in(10)_times(1000) 47.9±4.84ms 52.8±7.29ms +10.23%
query_block/query_block_in(10)_times(10000) 511.2±78.02ms 484.0±54.91ms -5.32%
query_block/query_block_in(1000)_times(100) 2.2±0.06ms 1120.6±60.85µs -49.06%
query_block/query_block_in(1000)_times(1000) 12.2±0.91ms 11.8±0.77ms -3.28%
query_block/query_block_in(1000)_times(10000) 119.9±12.78ms 133.4±18.77ms +11.26%
storage_transaction 1043.6±322.38µs 984.6±304.20µs -5.65%
vm/transaction_execution/1 462.9±38.75ms 440.1±39.54ms -4.93%
vm/transaction_execution/10 202.4±35.79ms 142.5±9.63ms -29.59%
vm/transaction_execution/20 150.9±15.03ms 135.5±13.60ms -10.21%
vm/transaction_execution/5 182.1±15.90ms 171.8±15.49ms -5.66%
vm/transaction_execution/50 157.8±18.26ms 156.7±11.62ms -0.70%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants