Skip to content

feat: add complex/parse-float32 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 2, 2024
Merged

feat: add complex/parse-float32 #1430

merged 6 commits into from
Mar 2, 2024

Conversation

kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 1, 2024 •
edited
Loading

Resolves #1332 .

Description

What is the purpose of this pull request?

This pull request:
Adds the package @stdlib/complex/parse-float32.

Related Issues

Does this pull request have any related issues?

This pull request:

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Tests:
Screenshot 2024-02-29 230900

Benchmarks
Screenshot 2024-02-29 230841

Examples
Screenshot 2024-02-29 230624

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Pranavchiku
Pranavchiku reviewed Mar 1, 2024
View reviewed changes
.gitignore
@@ -1,188 +0,0 @@
#/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please revert this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pranav I reverted this and also What are the changes I have to do, I changed it now please check

@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 1, 2024
Pranavchiku
Pranavchiku suggested changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't went much into lib/main.js overall it is good. Requested few changes, once addressed this will be ready to merge.

@kawaho2 kawaho2 requested a review from Pranavchiku March 2, 2024 10:32
@Pranavchiku
remove extra line
bb5ba55 
Signed-off-by: Pranav <[email protected]>
Pranavchiku
Pranavchiku approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 2, 2024
@Planeshifter Planeshifter merged commit 514d38f into stdlib-js:develop Mar 2, 2024
@kawaho2 kawaho2 deleted the parse-float32 branch March 2, 2024 17:23
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
@kawaho2 @Pranavchiku
feat: add complex/parse-float32
a5f357d 
PR-URL: stdlib-js#1430
Closes: stdlib-js#1332

---------

Signed-off-by: Rejoan Sardar <[email protected]>
Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
This was referenced Mar 17, 2024
Closed
Closed
@kawaho2 kawaho2 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

+1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/complex/parse-float32

4 participants

@kawaho2 @stdlib-bot @Pranavchiku @Planeshifter