Skip to content

feat: add C implementation for math/base/special/asech #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2024
Merged

feat: add C implementation for math/base/special/asech #1750

merged 3 commits into from
Mar 11, 2024

Conversation

kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 7, 2024

Resolves #862 .

Description

What is the purpose of this pull request?

This pull request: Add C implementation for @stdlib/math/base/special/asech

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 7, 2024
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/asech feat: add C implementation for math/base/special/asech Mar 8, 2024
@kawaho2
Copy link
Contributor Author

kawaho2 commented Mar 10, 2024

@Pranavchiku, @Planeshifter please review these PR,and let me know if any changes need to be made.

Pranavchiku
Pranavchiku reviewed Mar 10, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 10, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 10, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 10, 2024
View reviewed changes
Pranavchiku
Pranavchiku reviewed Mar 10, 2024
View reviewed changes
Pranavchiku
Pranavchiku approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything looks good to me. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2024
Planeshifter
Planeshifter reviewed Mar 11, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 11, 2024
View reviewed changes
@Planeshifter
Apply suggestions from code review
bfb0336 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit b56c697 into stdlib-js:develop Mar 11, 2024
@kawaho2 kawaho2 deleted the asech branch March 11, 2024 06:16
This was referenced Mar 17, 2024
Closed
Closed
@kawaho2 kawaho2 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

+1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/asech
3 participants
@kawaho2 @Planeshifter @Pranavchiku