Skip to content

feat: add C implementation for math/base/assert/is-nonnegative-finite #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: add C implementation for math/base/assert/is-nonnegative-finite #1829

merged 1 commit into from
Mar 11, 2024

Conversation

kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 11, 2024

Resolves #1828 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/assert/is-nonnegative-finite .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 11, 2024
@Planeshifter Planeshifter self-requested a review March 11, 2024 23:27
@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/assert/is-nonnegative-finite feat: add C implementation for math/base/assert/is-nonnegative-finite Mar 11, 2024
@Planeshifter
Copy link
Member

LGTM! Thanks!

@Planeshifter Planeshifter merged commit 229be91 into stdlib-js:develop Mar 11, 2024
@kawaho2 kawaho2 deleted the is-nonnegative-finite branch March 12, 2024 06:00
This was referenced Mar 17, 2024
Closed
Closed
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
@kawaho2 kawaho2 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/assert /is-nonnegative-finite

2 participants

@kawaho2 @Planeshifter