Skip to content

Bug #1178 - use Timepoint on get_ledger_timestamp#1282

Open
graydon wants to merge 1 commit into
mainfrom
timepoint-for-timestamp
Open

Bug #1178 - use Timepoint on get_ledger_timestamp#1282
graydon wants to merge 1 commit into
mainfrom
timepoint-for-timestamp

Conversation

@graydon
Copy link
Copy Markdown
Contributor

@graydon graydon commented Dec 2, 2023

Fixes #1178

This would be an env-breaking change if we do later. But it's also not super important? We can paper it over in the SDK or ship a different function in the future.

@graydon graydon requested review from a team, dmkozh and sisuresh as code owners December 2, 2023 04:56
@graydon
Copy link
Copy Markdown
Contributor Author

graydon commented Dec 2, 2023

(Discussed with @leighmcculloch and decided this won't make it this time around, so maybe never, who knows)

@leighmcculloch
Copy link
Copy Markdown
Member

(Discussed with @leighmcculloch and decided this won't make it this time around, so maybe never, who knows)

Sorry, I don't remember this. We must have been past the point where we were changing the API.

This relates to:

Can this PR be repurposed to adding a new host function that returns Timepoint? After it is released in the next protocol we can update the SDK to return Timepoint too.

Without this change Timepoint is hard to adopt since much of the time folks operate on "now" and modifications of now, and ledger close time is the closest thing to now that contract developers have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent time type usage

2 participants