Skip to content

Fixed TF problems with RTABmap example #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adujardin merged 2 commits into from
Nov 5, 2018
Merged

Fixed TF problems with RTABmap example #324

adujardin merged 2 commits into from
Nov 5, 2018

Conversation

@Myzhar
Copy link
Member

@Myzhar Myzhar commented Nov 5, 2018

Fixes #322

@Myzhar Myzhar added the Bug Fix label Nov 5, 2018
@Myzhar Myzhar requested a review from adujardin November 5, 2018 13:16
adujardin
adujardin requested changes Nov 5, 2018
View reviewed changes
Copy link
Member

@adujardin adujardin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we specify the RTABmap version in package.xml or somewhere? I had an older version installed and this fix broke it. It only works for a recent version of RTABmap it seems, right?
Edit : Nope it's fine, sorry my mistake 😉

@Myzhar
Copy link
Member Author

Myzhar commented Nov 5, 2018 •
edited
Loading

I use the RTABmap version provided with Ubuntu repository and I have no problems.
The version is 0.17.6 ($ rosversion rtabmap $ rosversion rtabmap_ros)

I can add this information in the readme

@adujardin adujardin merged commit 99cd29e into master Nov 5, 2018
@adujardin adujardin deleted the fix_rtabmap_example branch November 5, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adujardin adujardin adujardin approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Myzhar @adujardin