Skip to content

Disallow confirmation token reuse #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdchaney wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Disallow confirmation token reuse #98

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4e6e7b
Remove extraneous check for request.local?
mdchaney Jun 12, 2024
2e6e5b0
Adds assertions for remember_me cookie.
mdchaney Jun 12, 2024
9f1432a
Prevent reuse of confirmation token.
mdchaney Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds assertions for remember_me cookie. 
Asserts cookie is http_only, secure, and same-site is "strict".
Closes #87.
  • Loading branch information
@mdchaney
mdchaney committed Jun 12, 2024
commit 2e6e5b0757cedd4d2c530ea047f689f1fd7015cf
6 changes: 6 additions & 0 deletions test/controllers/sessions_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ class SessionsControllerTest < ActionDispatch::IntegrationTest

assert_not_nil current_user
assert_not_nil cookies[:remember_token]

remember_me_cookie = cookies.get_cookie("remember_token")

assert remember_me_cookie.http_only?
assert remember_me_cookie.secure?
assert_equal "Strict", remember_me_cookie.to_h["SameSite"]
end

test "should forget user when logging out" do
Expand Down