fix toString(JSONArray) to emit object.toString() values #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No one has posted comments or concerns, so this change will be merged. |
stleary
added a commit
that referenced
this pull request
May 2, 2015
…-JSONArray fix toString(JSONArray) to emit object.toString() values
1 task
This was referenced Jul 5, 2021
1 task
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and post any questions or concerns.
Might have misplaced the branch notes, which are included here:
What problem does this code solve?
JSONML converts XML to JSONObject or JSONArray objects. The corresponding toString() methods should generate similar XML.
Does the change conflict with the JSON spec?
No
Any changes to the API?
No
Any changes to how the code behaves?
No changes to exception behavior. JSONML.toString(JSONArray) will now include object.toString(), in addition to string, JSONObject, and JSONArray content output. E.G. boolean output. This will change the output for some XML inputs.
Does it break the unit tests?
Yes, but see [https://github.com/stleary/JSON-Java-unit-test/tree/JSONMLTest-for-toString-issue], which will be committed if/when this change is merged.
Should the documentation be updated?
No