change to public: write(writer, indentfactor, indent) #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stleary
added a commit
that referenced
this pull request
Dec 30, 2015
change to public: write(writer, indentfactor, indent)
1 task
This was referenced Jul 5, 2021
1 task
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Some users prefer more fine tuned control over JSONObject.write() and JSONArray.write()
Changes to the API?
JSONObject.write(Writer writer, int indentFactor, int indent) and JSONArray.write(Writer writer, int indentFactor, int indent) are both made public
Changes to how the code behaves?
No.
Does it break the unit tests?
No. No unit tests were added since the coverage of these two methods is already acceptable.
Will this require a new release?
No, this change will be rolled into the next release.
Should the documentation be updated?
No.