Rework PWM_RESOLUTION #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no more distinction between pwm resolution at arduino API level and at HardwareTimer level. PWM_RESOLUTION is default resolution (Arduinio API and HardwareTimer) It is set to 8bit like default arduino pwm resolution. HardwareTimer resolution can now take any value from 1bit to 16bit (like Arduino API). Remove variant PWM_RESOLUTION configuration when it is set to 8, as it is already the default value. Fixes stm32duino#790
ABOSTM
force-pushed
the
HARDWARETIMER_PWMRESOLUTION
branch
from
0979ffe to
9f74349
Compare
fpistm
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rework
PWM_RESOLUTIONThere is no more distinction between pwm resolution
at Arduino API level and at HardwareTimer level.
PWM_RESOLUTIONis default resolution (Arduinio API and HardwareTimer)It is set to 8 bits like default Arduino pwm resolution.
HardwareTimer resolution can now take any value from 1bit to 16bit
(like Arduino API).
Remove variant
PWM_RESOLUTIONconfiguration when it is set to 8,as it is already the default value.
Fixes #790