Skip to content

MDX: Compile to improved source-loader format #10084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2020
Merged

MDX: Compile to improved source-loader format #10084

merged 4 commits into from
Mar 10, 2020

Conversation

@shilman
Copy link
Member

@shilman shilman commented Mar 9, 2020 •
edited
Loading

Issue: #7479

What I did

#9547 cleaned up the source loader to generate a storySource story parameter. In this PR, I use that as the compilation target for the MDX target, and remove a bunch of dead code.

How to test

  • See updated snapshots
  • See working MDX examples in official-storybook

@shilman shilman added this to the 6.0.0 milestone Mar 9, 2020
@shilman shilman requested a review from igor-dv as a code owner March 9, 2020 17:04
@shilman shilman requested a review from tmeasday March 9, 2020 17:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2020 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against f2a5d55

tmeasday
tmeasday approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman mentioned this pull request Mar 10, 2020
Merged
3 tasks
@shilman
Copy link
Member Author

shilman commented Mar 10, 2020

Merging based on TeamCity CI

@shilman shilman merged commit 1af0458 into next Mar 10, 2020
@shilman shilman mentioned this pull request Mar 10, 2020
Closed
@ghost ghost mentioned this pull request Jan 15, 2021
Merged
@stof stof deleted the 7479-mdx-storysource-compat branch May 25, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmeasday tmeasday tmeasday approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

No one assigned

Labels

addon: docs addon: storysource block: source BREAKING CHANGE mdx source-loader

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shilman @tmeasday