Updated issue triage guidelines #1024
Conversation
|
@shilman I think this branch is messed up, I don't see any changes |
|
@tmeasday sorry my bad. fixed! |
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=========================================
Coverage ? 12.51%
=========================================
Files ? 196
Lines ? 4458
Branches ? 713
=========================================
Hits ? 558
Misses ? 3269
Partials ? 631Continue to review full report at Codecov.
|
|
Looks good--want to add a description of what |
| Once you've helped out on a few issues, if you'd like triage access you can help label issues and respond to reporters. | ||
|
|
||
| We use the following label scheme to categorize issues: | ||
| - **type** - `bug`, `feature`, `question / support`, `discussion`, `greenkeeper`, `maintenance`. |
There was a problem hiding this comment.
I think a label feature / change request might be more descriptive.
CONTRIBUTING.md
Outdated
|
|
||
| - Unreproducible issues should be closed if it's not possible to reproduce them (if the reporter drops offline, it is reasonable to wait 2 weeks before closing). | ||
|
|
||
| - `bug`s should be closed when the issue is fixed and merged to `master` |
There was a problem hiding this comment.
merged to master or released?
There was a problem hiding this comment.
I think merged myself. Otherwise we need another label fixed or the like and we mentally have to ignore fixed issues. I appreciate users might not find an issue that has been closed but not yet released however.
There was a problem hiding this comment.
Although maybe it's easier for us to ignore fixed issues, and we can use them to construct a meaningful changelog. I change my vote ;)
|
Good work! |
|
Could we add a description or clarify use cases for labels:
does One more not related to this PR but possible worth to discuss. Should we ask people to add [prefix] with area/type label when they submitting an issue/PR since they can't add labels themselves? |
|
@usulpro Those are all great points. I'm going to merge this now and will follow up on the status-related labels in a separate PR. |
ndelangen
added
cleanup
|
View your CI Pipeline Execution ↗ for commit 674d6e2
☁️ Nx Cloud last updated this comment at |
4 participants
Issue: #733
What I did
@tmeasday and I sat down and reworked the issue labels in the Storybooks repo. This change summarizes the changes we made. Separately we will propose some guidelines around closing issues that have gone stale, etc.
How to test
N/A