Upgraded webpack PostCSS plugin definition #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
May 19, 2017
Member
|
First merge! 🍾 |
ndelangen
added
the
cleanup
|
View your CI Pipeline Execution ↗ for commit 63e5dc2
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1061 No PostCSS config found
What I did
It seems like either the config is defined differently in Webpack 2 or we upgraded to a newer version of PostCSS. PostCSS can't read our current plugin definition so I upgraded it to the latest listed on the docs.
How to test
import 'styles.css', orrequire('styles.css').it should not throw an error during build and console log the style-loader contents.